This repository was archived by the owner on Feb 25, 2025. It is now read-only.
When setting up AOT snapshots from symbol references, make buffer sizes optional. #10674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
Aug 7, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2019
…ffer sizes optional. (flutter/engine#10674)
This was referenced Aug 9, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2019
…ffer sizes optional. (flutter/engine#10674)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 9, 2019
…ffer sizes optional. (flutter/engine#10674)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 9, 2019
git@github.com:flutter/engine.git/compare/dd735c917929...ff49ca1 git log dd735c9..ff49ca1 --no-merges --oneline 2019-08-09 dnfield@google.com Make firebase test more LUCI friendly (flutter/engine#10783) 2019-08-09 chinmaygarde@gmail.com Add a test for creating images from bytes. (flutter/engine#10799) 2019-08-09 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 1nsfv... to 9xVXx... (flutter/engine#10798) 2019-08-09 chinmaygarde@gmail.com Wire up a concurrent message loop backed SkExecutor for Skia. (flutter/engine#10788) 2019-08-09 stuartmorgan@google.com Roll buildroot for ANGLE support (flutter/engine#10784) 2019-08-09 chinmaygarde@gmail.com When setting up AOT snapshots from symbol references, make buffer sizes optional. (flutter/engine#10674) 2019-08-09 egarciad@google.com Include Maven dependency in files.json (flutter/engine#10719) 2019-08-09 liyuqian@google.com Remove 3 semi-redundant try-jobs (flutter/engine#10786) 2019-08-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 04580795746b..4d557e3df433 (4 commits) (flutter/engine#10794) 2019-08-09 jason-simmons@users.noreply.github.com Build JARs containing the Android embedding sources and the engine native library (flutter/engine#10778) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (jimgraham@google.com), and stop the roller if necessary.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedders don't have this information (since they probably access the same using dlsym). The engine only uses the same for instrumentation. There is no reason to gate engine launch on advisory information (or make callers fake the same).