Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Contributor

@chinmaygarde chinmaygarde commented Aug 3, 2019

We are severely resource constrained on the tryjobs. This is hindering progress on ToT due to scheduling failures and rate limits. There are no plans to requisition more resources in this infra scheme as the migration to tryjobs on LUCI is the preferred way forward. This patch removes presubmits that are somewhat redundant. Each removed presubmit and the justification is given below:

  • build_and_test_linux_opt_release: The AOT variant is tested by build_and_test_linux_opt_profile (actually its replacement, see the next point).
  • build_and_test_linux_opt_profile: When we build the host profile variant for Android, we test it as well instead of building the extra variant (since we already need a host for a target build).
  • build_and_test_android_unopt_debug: gen_javadoc have been moved to the profile variant. Roboelectric tests have been moved to profile variant. JIT infra will be tested by the the host tests.
  • ToT framework checks: These will be performed by the autoroller which also has a sheriff rotation. This will also avoid us having to ignore red presubmits on manual changes.

Everything else is left as-is. To be clear, this causes strictly less checks to be performed on each commit.

We are severely resource constrained on the tryjobs. This is hindering progress on ToT due to scheduling failures and rate limits. There are no plans to requisition more resources in this infra scheme as the migration to tryjobs on LUCI is the preferred way forward. This patch removes presubmits that are somewhat redundant. Each removed presubmit and the justification is given below:

* `build_and_test_linux_opt_release`: The AOT variant is tested by `build_and_test_linux_opt_profile` (actually its replacement, see the next point).
* `build_and_test_linux_opt_profile`: When we build the host profile variant for Android, we test it as well instead of building the extra variant (since we already need a host for a target build).
* `build_and_test_android_unopt_debug`: `gen_javadoc` have been moved to the profile variant. `Roboelectric` tests have been moved to profile variant. JIT infra will be tested by the the host tests.
* ToT framework checks: These will be performed (by the autoroller)[https://autoroll.skia.org/r/flutter-engine-flutter-autoroll?tab=status] which also has a sheriff rotation. This will also avoid us having to ignore red presubmits on manual changes.

Everything else is left as-is. To be clear, this causes strictly less checks to be performed on each commit.
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

We will be able to start trying luci for presubmits soon.

@chinmaygarde chinmaygarde merged commit 16c0058 into flutter:master Aug 6, 2019
@chinmaygarde chinmaygarde deleted the cirrus_cull2 branch August 6, 2019 23:16
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 7, 2019
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Aug 7, 2019
git@github.com:flutter/engine.git/compare/42917704790d...9bfa4f5

git log 4291770..9bfa4f5 --no-merges --oneline
2019-08-07 stuartmorgan@google.com Roll buildroot back to an earlier version (flutter/engine#10681)
2019-08-07 stuartmorgan@google.com Roll buildroot to pick up EGL library name fix (flutter/engine#10679)
2019-08-06 chinmaygarde@google.com Remove semi-redundant try-jobs. (flutter/engine#10485)
2019-08-06 chinmaygarde@google.com Allow embedders to control Dart VM lifecycle on engine shutdown. (flutter/engine#10652)
2019-08-06 matthew-carroll@users.noreply.github.com Android embedding refactor pr40 add static engine cache (flutter/engine#10481)
2019-08-06 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from W6ZtV... to 9sR9P... (flutter/engine#10672)
2019-08-06 bkonyi@google.com Roll src/third_party/dart 574c4a51c6..c262cbd414 (11 commits)
2019-08-06 stuartmorgan@google.com Roll buildroot for ANGLE support (flutter/engine#10667)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (jimgraham@google.com), and stop
the roller if necessary.
liyuqian added a commit to liyuqian/engine that referenced this pull request Aug 7, 2019
liyuqian added a commit to liyuqian/engine that referenced this pull request Aug 8, 2019
This is a subset of flutter#10485.
Hopefully this doesn't significantly reduce our coverage since we
have now limited the fuchsia auto-roller frequency.
liyuqian added a commit that referenced this pull request Aug 9, 2019
This is a subset of #10485.
Hopefully this doesn't significantly reduce our coverage since we
have now limited the fuchsia auto-roller frequency.
cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Aug 16, 2019
We are severely resource constrained on the tryjobs. This is hindering progress on ToT due to scheduling failures and rate limits. There are no plans to requisition more resources in this infra scheme as the migration to tryjobs on LUCI is the preferred way forward. This patch removes presubmits that are somewhat redundant. Each removed presubmit and the justification is given below:

* `build_and_test_linux_opt_release`: The AOT variant is tested by `build_and_test_linux_opt_profile` (actually its replacement, see the next point).
* `build_and_test_linux_opt_profile`: When we build the host profile variant for Android, we test it as well instead of building the extra variant (since we already need a host for a target build).
* `build_and_test_android_unopt_debug`: `gen_javadoc` have been moved to the profile variant. `Roboelectric` tests have been moved to profile variant. JIT infra will be tested by the the host tests.
* ToT framework checks: These will be performed (by the autoroller)[https://autoroll.skia.org/r/flutter-engine-flutter-autoroll?tab=status] which also has a sheriff rotation. This will also avoid us having to ignore red presubmits on manual changes.

Everything else is left as-is. To be clear, this causes strictly less checks to be performed on each commit.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants