Commits on Oct 21, 2020

1. Ensure root isolate create callback is invoked before the isolate is … …

   …in the running phase. (#22041)
   
   Embedders that have access to the Dart native API (only Fuchsia now) may perform
   library setup in the isolate create callback. The engine used to depend on the
   fact the root isolate entrypoint is invoked in the next iteration of message
   loop (via the `_startIsolate` trampoline in `isolate_patch.dart`) to ensure that
   library setup occur before the main entrypoint was invoked. However, due to
   differences in the way in which message loops are setup in Fuchsia, this
   entrypoint was run before the callback could be executed. Dart code on Fuchsia
   also has the ability to access the underlying event loops directly. This patch
   moves the invocation of the create callback to before user dart code has a
   chance to run. This difference in behavior on Fuchsia became an issue when the
   isolate initialization was reworked in #21820
   for null-safety.
   
   Another issue was discovered in that the callback was being invoked twice, I
   fixed that too and added a test.
   
   Fixes flutter/flutter#68732

   

   chinmaygarde authored Oct 21, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for f459a86
   • Browse repository at this point

   Copy the full SHA

   f459a86 View commit details

   Browse the repository at this point in the history