Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: f7c7b41
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 564367b
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on Sep 9, 2020

  1. Roll Skia from 81606b5 to 215d2b0 (4 revisions) (#21045)

    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    c0abf5b View commit details
    Browse the repository at this point in the history

  2. Roll Fuchsia Mac SDK from Phn3nF_BJ... to K1oZWWtBn... (#21051)

    @skia-flutter-autoroll
    skia-flutter-autoroll authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    1fb1337 View commit details
    Browse the repository at this point in the history

  3. Check for dart2js on felt startup (#21046) 

    This adds a check for the presence of dart2js in the engine build.

Felt relies on an engine build with `--full-dart-sdk` set. Previously,
we checked for the presence of pub, but not for the presence of
web-specific tooling such as dart2js that felt relies on. Pub is built
as part of the default Dart SDK build when `--full-dart-sdk` is not set,
so its presence is insufficient to prove that other required tooling is
present.

Without this check, we get the following error on run:

    Unhandled exception:
    ProcessException: No such file or directory
      Command: /Users/cbracken/src/flutter/engine/src/out/host_debug_unopt/dart-sdk/bin/dart2js --no-minify --disable-inlining --enable-asserts --enable-experiment=non-nullable --no-sound-null-safety -O2 -o test/paragraph_builder_test.dart.browser_test.dart.js test/paragraph_builder_test.dart
    @cbracken
    cbracken authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    404e9b7 View commit details
    Browse the repository at this point in the history

  4. Increase thread priority before engine init (#20922) 

    We get huge ANRs in not pure flutter app.
We found that 0.15% of the engine initialization took more than 10 seconds, every 10 million starts.
    @linxuebin1990
    linxuebin1990 authored Sep 9, 2020
    Configuration menu
    Copy the full SHA
    564367b View commit details
    Browse the repository at this point in the history
Loading