Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bf25922
Choose a base ref
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0693ee0
Choose a head ref
  • 9 commits
  • 32 files changed
  • 5 contributors

Commits on Nov 4, 2020

  1. Reland: Use dispatchKeyEventPreIme, and handle keys sent to InputConn…

    …ection.sendKeyEvent on Android (#22304)
    
    This re-lands #21163, which was reverted in #22004
    
    Now that flutter/flutter#67359 has landed, this change will no longer cause spaces (and other shortcuts) to be ignored in text fields if there is no action associated with the intent, even if there is a shortcut key mapping to an intent.
    
    It also no longer causes web test failures (as far as I can tell without submitting it: the same tests don't fail locally).
    
    Here's the original PR description:
    
    This switches from using dispatchKeyEvent to using dispatchKeyEventPreIme so that keys can be intercepted before they reach the IME and be handled by the framework.
    
    It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends the to Flutter before sending them to the IME (which it now only does if they are not handled by the framework).
    
    This fixes the problem where pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system.
    
    Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent.
    gspencergoog authored Nov 4, 2020
    Configuration menu
    Copy the full SHA
    7a8057b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2020

  1. Configuration menu
    Copy the full SHA
    a8ec74f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e66a720 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3105db8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8173f91 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    9f83bc3 View commit details
    Browse the repository at this point in the history
  6. Revert "Reland: Use dispatchKeyEventPreIme, and handle keys sent to I…

    …nputConnection.sendKeyEvent on Android (#22304)" (#22321)
    
    This reverts commit 7a8057b because it breaks back button functionality.
    gspencergoog authored Nov 5, 2020
    Configuration menu
    Copy the full SHA
    5d481fb View commit details
    Browse the repository at this point in the history
  7. [linux] Change the buildroot DEPS for Linux Arm64 support (#22284)

    Hidenori Matsubayashi authored Nov 5, 2020
    Configuration menu
    Copy the full SHA
    03023e0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0693ee0 View commit details
    Browse the repository at this point in the history
Loading