Comparing changes

After #53099, impeller is always enabled, even if the manifest disables it using `io.flutter.embedding.android.EnableImpeller`. This PR causes it to respect the manifest value if it is explicitly disabled. Fixes b/343603270 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

https://skia.googlesource.com/skia.git/+log/949b8cefbf87..693d9362f0f6 2024-05-30 jvanverth@google.com Revert "Fix text 565 to RGBA conversion on BGRA-based systems." 2024-05-30 michaelludwig@google.com [skif] Disable padding on dithered FilterResults If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…ci/android_debug. (#53107) Part of flutter/flutter#131711. Also, stops distributing `flutter_gpu` as part of the host artifacts, since it's not target-specific. This enables us to use the same distribution mechanism as the `sky_engine` package. Corresponding framework PR: flutter/flutter#149299

https://skia.googlesource.com/skia.git/+log/693d9362f0f6..eadc654480ed 2024-05-30 egdaniel@google.com [Graphite] Add descriptor set cache for Vulkan uniforms. 2024-05-30 kjlubick@google.com Add link deps to lowest skia_cc_library 2024-05-30 michaelludwig@google.com Reland "[skif] Take advantage of PixelBoundary in rescale()" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Add `SemanticsAction.focus`. This PR just adds the new enum value without any logic. Adding the enum value first to unblock work that needs to be done on both the engine and framework side that will actually implement all the necessary logic. This is PR 1 out of ~3 for flutter/flutter#83809

https://dart.googlesource.com/sdk.git/+log/ef405fbe3917..2976c1694eed 2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-209.0.dev 2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-208.0.dev 2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-207.0.dev 2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-206.0.dev 2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-205.0.dev 2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-204.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/eadc654480ed..75cf7d351b02 2024-05-30 robertphillips@google.com Revert "[Ganesh] Make GL Protectedness behave more like Vulkan Protectedness" 2024-05-30 michaelludwig@google.com [graphite] Remove mipmapping from ProxyCache If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…53108)" (#53124) Reverts: #53108 Initiated by: jonahwilliams Reason for reverting: Probably --no-enable-impeller isn't working Original PR Author: jiahaog Reviewed By: {jonahwilliams} This change reverts the following previous change: After #53099, impeller is always enabled, even if the manifest disables it using `io.flutter.embedding.android.EnableImpeller`. This PR causes it to respect the manifest value if it is explicitly disabled. Fixes b/343603270 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…53125) Reverts: #53099 Initiated by: jonahwilliams Reason for reverting: manifest opt out doens't work. Original PR Author: jonahwilliams Reviewed By: {bdero, zanderso, chinmaygarde} This change reverts the following previous change: All plugin migrations have landed. Enable impeller by default on Android.

b/335285098 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord].  [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat

https://skia.googlesource.com/skia.git/+log/75cf7d351b02..7cfb0898ac15 2024-05-30 jvanverth@google.com Reland "Fix text 565 to RGBA conversion on BGRA-based systems." 2024-05-30 nicolettep@google.com [graphite] Rm unused attribute and correct format logic 2024-05-30 kjlubick@google.com Fix duplicated sources in ganesh_vulkan rule If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

#53119)" (#53128) Reverts: #53119 Initiated by: zanderso Reason for reverting: Macros package version issues blocking the roll to the framework https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8746489765266754081/+/u/flutter_config_--clear-features/stdout Original PR Author: skia-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: https://dart.googlesource.com/sdk.git/+log/ef405fbe3917..2976c1694eed 2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-209.0.dev 2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-208.0.dev 2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-207.0.dev 2024-05-30 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-206.0.dev 2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-205.0.dev 2024-05-29 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.5.0-204.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC dart-vm-team@google.com,jacksongardner@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

https://skia.googlesource.com/skia.git/+log/7cfb0898ac15..188ad395c3e7 2024-05-30 nathanasanchez@google.com Change graphite conical gradient implementation 2024-05-30 egdaniel@google.com [Graphite] Fix key creation for vulkan uniform desc sets. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC brianosman@google.com,bwils@google.com,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

The DisplayListBuilder now tracks the blend mode(s) used for its contents and whether it contains a child SaveLayer that uses a backdrop filter - both conditions that could require the graphics engine to use a different type of layer to satisfy the requests. blend modes are tracked as the "highest" blend mode enum used by any content (defaults to kClear) as the enum values tend to be ordered so that larger values will tend to require more complicated render-target accesses. The root layer of the DisplayList can be queried for both conditions on the root layer using methods on the DisplayList class.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comparing changes

Open a pull request

Commits on May 30, 2024

This comparison is taking too long to generate.

Uh oh!