This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: flutter/engine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: bf259226b224
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: flutter/engine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0693ee04d130
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 9 commits
- 32 files changed
- 5 contributors
Commits on Nov 4, 2020
-
Reland: Use dispatchKeyEventPreIme, and handle keys sent to InputConn…
…ection.sendKeyEvent on Android (#22304) This re-lands #21163, which was reverted in #22004 Now that flutter/flutter#67359 has landed, this change will no longer cause spaces (and other shortcuts) to be ignored in text fields if there is no action associated with the intent, even if there is a shortcut key mapping to an intent. It also no longer causes web test failures (as far as I can tell without submitting it: the same tests don't fail locally). Here's the original PR description: This switches from using dispatchKeyEvent to using dispatchKeyEventPreIme so that keys can be intercepted before they reach the IME and be handled by the framework. It also now intercepts key events sent to InputConnection.sendKeyEvent, as some IMEs do (e.g. the Hacker's Keyboard), and sends the to Flutter before sending them to the IME (which it now only does if they are not handled by the framework). This fixes the problem where pressing TAB on a hardware keyboard sends the tab to both the text field and to the focus traversal system. Note that we still can't intercept all keystrokes given to a soft keyboard, only those which the soft keyboard decides to send to InputConnection.sendKeyEvent.
Configuration menu - View commit details
-
Copy full SHA for 7a8057b - Browse repository at this point
Copy the full SHA 7a8057bView commit details
Commits on Nov 5, 2020
-
Configuration menu - View commit details
-
Copy full SHA for a8ec74f - Browse repository at this point
Copy the full SHA a8ec74fView commit details -
Roll the path package in web_ui and web_test_utils to match the versi…
…on used by the framework (#22309)
Configuration menu - View commit details
-
Copy full SHA for e66a720 - Browse repository at this point
Copy the full SHA e66a720View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3105db8 - Browse repository at this point
Copy the full SHA 3105db8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8173f91 - Browse repository at this point
Copy the full SHA 8173f91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f83bc3 - Browse repository at this point
Copy the full SHA 9f83bc3View commit details -
Revert "Reland: Use dispatchKeyEventPreIme, and handle keys sent to I…
Configuration menu - View commit details
-
Copy full SHA for 5d481fb - Browse repository at this point
Copy the full SHA 5d481fbView commit details -
[linux] Change the buildroot DEPS for Linux Arm64 support (#22284)
Hidenori Matsubayashi authoredNov 5, 2020 Configuration menu - View commit details
-
Copy full SHA for 03023e0 - Browse repository at this point
Copy the full SHA 03023e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0693ee0 - Browse repository at this point
Copy the full SHA 0693ee0View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff bf259226b224...0693ee04d130