[Property Editor] Show reconnection overlay when disconnection detected #9043
Conversation
|
|
||
| static const _editableArgsDebounceDuration = Duration(milliseconds: 600); | ||
|
|
||
| static const _checkConnectionInterval = Duration(seconds: 5); |
There was a problem hiding this comment.
do we need to check this frequently?
There was a problem hiding this comment.
Hmm it looks like no! It seems like the timer starts immediately after the tab is re-awoken, so even setting this to 1 minute means the overlay is displayed immediately after returning from sleep.
| return Timer.periodic(interval, (timer) async { | ||
| final isClosed = await editorClient.isClientClosed(); | ||
| if (isClosed) { | ||
| _shouldReconnect.value = true; |
There was a problem hiding this comment.
does this value ever get set back to false?
There was a problem hiding this comment.
No, but because the IFRAME is then re-loaded the whole Property Editor is re-initialized again (with the default value false). I could reset to false though I don't know if it would ever actually be called.
| Widget build(BuildContext context) { | ||
| final theme = Theme.of(context); | ||
| return Container( | ||
| color: theme.colorScheme.surface.withValues(alpha: 0.5), |
There was a problem hiding this comment.
use theme.colorScheme.semiTransparentOverlayColor. In fact, bonus points for pulling the overlay message out of timeline_events_view.dart into a shared widget to use here and in timeline_events_view.dart.
There was a problem hiding this comment.
Done, pulled this into shared widget
There was a problem hiding this comment.
FYI here is what the Timeline events overlay now looks like (should be the same as before)
Work towards #9028, #1948
Implements the first step described in this comment: #9028 (comment)
Follow-up after this is to add an
isClosedgetter topackage:dtdso that instead we can check whether DTD is closed instead of sending it an empty request. Want to do that in a separate PR however in case we decide we should cherry-pick this into the current Flutter beta (and therefore we don't need to coordinate a DTD cherrypick at the same time.)