Compile devtools with release mode (no dart2js optimization set)
#7485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@kenzieschmoll pointed out we have a lot of checks for whether we are in release mode (e.g. to collect analytics). Switching to just plain release mode instead of profile mode without setting the dart2js optimization level. |
profile moderelease mode (no dart2js optimization set)
Comment on lines
-98
to
-99
| // Enable default optimizations: https://dart.dev/tools/dart-compile#js | ||
| '--dart2js-optimization=O1', |
Member
There was a problem hiding this comment.
do we need the --release arg here?
Member
Author
There was a problem hiding this comment.
Nope, that's passed as the buildMode (below)
kenzieschmoll
approved these changes
Mar 27, 2024
|
auto label is removed for flutter/devtools/7485, due to - The status or check suite Verify PR Release Note Requirements has failed. Please fix the issues identified (or deflake) before re-applying this label. |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 28, 2024
Follow up to https://dart-review.googlesource.com/c/sdk/+/360181 with one more patch: flutter/devtools#7485 Bug: flutter/devtools#7483 Change-Id: Ia2a93c783827d7e894ac139ecba9850edc8dff20 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/360123 Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com> Reviewed-by: Jacob Richman <jacobr@google.com> Commit-Queue: Elliott Brooks <elliottbrooks@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Dart-Code/Dart-Code#5049
Without this change, seeing infinite spinner:
With this change, Flutter sidebar loads: