-
Notifications
You must be signed in to change notification settings - Fork 364
Build and test DevTools from the latest flutter candidate branch #4582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
51c437b to
2947adf
Compare
CoderDake
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still reviewing some stuff here, but pushing up some comments early
| permissions: read-all | ||
|
|
||
| env: | ||
| AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE!
|
|
||
| import 'compare.dart'; | ||
|
|
||
| class SemanticVersion with CompareMixin { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty for moving this to a common location!
71b694b to
3d15cdf
Compare
rename release_note_helper First step towards an official verify :D add verify command add ability to print markdown make it just for a single release plural urls and add urls try the stuff Use PointerInterceptor in dialogs to allow clicks over an iFrame (flutter#4578) UX improvement to banner warnings and errors (flutter#3537) * UX improvement to banner warnings and errors * review comments * update goldens Add Use Legacy Trace Viewer setting to the Performance page (flutter#4579) Add button to toggle visibility of the Flutter frames chart (flutter#4577) Bump actions/checkout from 3.0.2 to 3.1.0 (flutter#4574) Bumps [actions/checkout](https://github.com/actions/checkout) from 3.0.2 to 3.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@2541b12...93ea575) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Simplify loading data into perfetto iFrame (flutter#4580) Add --update-perfetto option to build scripts (flutter#4581) Add details to diff. (flutter#4549) Include the full path for Perfetto assets (flutter#4585) * Include the full path for Perfetto assets * fix * review comments Improvements for release documentation (flutter#4575) Update feature_flags.dart (flutter#4584) try clone repo try new paths Add case study for memory diffing. (flutter#4589) Build and test DevTools from the latest flutter candidate branch (flutter#4582) Update version tool logic for `dev` versions (flutter#4536) Update CONTRIBUTING.md (flutter#4588) Bump to dev version 2.19.0-dev.0 (flutter#4594) Clicking on file name selects file (flutter#4409) oops cd order this has a higher likelyhood to do the trikc uses seperate :D
This PR:
pinnedandmasterbot flavorsClean up
devtools_sharedso that it can be reused by thetool/package