Skip to content

Conversation

@keyonghan
Copy link
Contributor

Before this PR, it queries recent history data regardless of branches.
With this PR, it uses default master.

@digiter
Copy link
Contributor

digiter commented Apr 14, 2020

Could you explain why the change in addition to what?

@keyonghan
Copy link
Contributor Author

This is a follow up PR for #746, which deals with commits. This PR focuses on TimeseriesValue.
API /api/public/get-timeseries-history queries both commits and TimeseriesValue, and they both need to consider branch.

Copy link
Contributor

@digiter digiter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keyonghan keyonghan merged commit 40af685 into flutter:master Apr 15, 2020
@keyonghan keyonghan deleted the timeseries_history_branch branch March 13, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants