Query commit list using branch filter for benchmark history #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digiter
reviewed
Apr 11, 2020
| // Queries for recent commits without considering branches. | ||
| // TODO(keyonghan): combine this function with the above `queryRecentCommits`, | ||
| // this needs to fix https://github.com/flutter/flutter/issues/52694. | ||
| Stream<Commit> queryRecentCommitsNoBranch({int limit = 100, int timestamp}) { |
Contributor
There was a problem hiding this comment.
Is it ready to remove this function everywhere?
Contributor
Author
There was a problem hiding this comment.
Not yet, task reservation is still using it: https://github.com/flutter/cocoon/blob/master/app_dart/lib/src/service/task_provider.dart#L30
Contributor
There was a problem hiding this comment.
Can we remove that one altogether?
Contributor
Author
There was a problem hiding this comment.
Actually it is not a simple removal thing. As for task reservation, we need to treat all tasks equally no matter which branch it is, and reserve based on only time. So, we need to keep the NoBranch function at this moment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes: flutter/flutter#52694