-
Notifications
You must be signed in to change notification settings - Fork 100
refresh chromebot status #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| // RefreshChromebotStatus pulls down the latest chromebot builds and updates the | ||
| // corresponding task statuses. | ||
| func RefreshChromebotStatus(cocoon *db.Cocoon, inputJSON []byte) (interface{}, error) { | ||
| linuxResults, err := refreshChromebot(cocoon, "linux_bot", "Linux") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More out of curiosity - would these two refresh calls to good candidates for go routines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On app engine goroutines are multiplexed over a single system thread, so there won't be any parallelism on the server. We might be able to run URL fetches in parallel but I didn't find anything in the docs about that.
|
lgtm |
…ice class (#3026) We are getting alert for 500 errors from the /api/github/webhook-branch-subscription endpoint when attempting to insert a commit for a release branch. The issue is with the timestamp presumably being null when we attempt to insert it into the database since it not a field in the return RepositoryCommit in the github lib. ``` "Failed to process Instance of 'PushMessage'. (500) Invalid argument(s): Error while encoding entity (Bad state: Property validation failed for property timestamp while trying to serialize entity of kind Commit. , #0 _ModelDescription._encodeProperty (package:gcloud/src/db/model_db_impl.dart:449:7) #1 _ModelDescription.encodeModel.<anonymous closure> (package:gcloud/src/db/model_db_impl.dart:429:7) #2 _LinkedHashMapMixin.forEach (dart:collection-patch/compact_hash.dart:625:13) #3 _ModelDescription.encodeModel (package:gcloud/src/db/model_db_impl.dart:428:34) #4 ModelDBImpl.toDatastoreEntity (package:gcloud/src/db/model_db_impl.dart:121:31) #5 _commitHelper (package:gcloud/src/db/db.dart:434:38) #6 Transaction.commit (package:gcloud/src/db/db.dart:118:14) #7 DatastoreService.insert.<anonymous closure>.<anonymous closure> (package:cocoon_service/src/service/datastore.dart:254:31) #8 DatastoreDB.withTransaction.<anonymous closure> (package:gcloud/src/db/db.dart:324:32) #9 _rootRunUnary (dart:async/zone.dart:1407:47) <asynchronous suspension> #10 DatastoreService.insert.<anonymous closure> (package:cocoon_service/src/service/datastore.dart:252:11) <asynchronous suspension> #11 RetryOptions.retry (package:retry/retry.dart:131:16) <asynchronous suspension> #12 DatastoreService.insert (package:cocoon_service/src/service/datastore.dart:250:7) <asynchronous suspension> #13 CommitService.handleCreateGithubRequest (package:cocoon_service/src/service/commit_service.dart:42:7) <asynchronous suspension> #14 GithubBranchWebhookSubscription.post (package:cocoon_service/src/request_handlers/github/branch_subscription.dart:56:7) <asynchronous suspension> #15 RequestHandler.service.<anonymous closure> (package:cocoon_service/src/request_handling/request_handler.dart:53:24) <asynchronous suspension> #16 SubscriptionHandler.service (package:cocoon_service/src/request_handling/subscription_handler.dart:138:5) <asynchronous suspension> #17 main.<anonymous closure>.<anonymous closure> (file:///app/bin/server.dart:303:11) <asynchronous suspension> ``` The data returned by the call in the Commit Service looks like this: ``` { "sha": "6fd42536b7697eb4bd2a698b19308e0aacac70c7", "node_id": "C_kwDOAeUeuNoAKDZmZDQyNTM2Yjc2OTdlYjRiZDJhNjk4YjE5MzA4ZTBhYWNhYzcwYzc", "commit": { "author": { "name": "Xilai Zhang", "email": "xilaizhang@google.com", "date": "2023-08-30T02:59:02Z" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "date": "2023-08-30T02:59:02Z" }, "message": "[flutter roll] Revert \"Fix `Chip.shape`'s side is not used when provided in Material 3\" (#133615)\n\nReverts flutter/flutter#132941\r\ncontext: b/298110031\r\n\r\nThe rounded rectangle borders don't appear in some of the internal\r\ngolden image tests.", "tree": { "sha": "e5efe7f39155d9b8fc40ad0a59c72f6a36f8b66d", "url": "https://api.github.com/repos/flutter/flutter/git/trees/e5efe7f39155d9b8fc40ad0a59c72f6a36f8b66d" }, ``` The author field in this case has no createdAt timestamp. *List which issues are fixed by this PR. You must list at least one issue.* Fixes flutter/flutter#133707 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
/cc @devoncarew