Roll forward #4254 with fixes/tests (always set FLUTTER_PREBUILT_ENGINE_VERSION from framework tests)
#4261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ework-stage PRs. (flutter#4254)" (flutter#4259)" This reverts commit 60a4a71.
jtmcdole
reviewed
Feb 26, 2025
| await unlockMergeQueueGuard(slug, sha, checkRunGuard); | ||
| } | ||
|
|
||
| /// Fetches, and schedules, tests that execute _after_ the engine is built. |
Member
There was a problem hiding this comment.
nit: This makes it sound like we can call this at any time and it'll run after the engine is built.
Maybe "schedules post-engine tests"?
|
|
||
| /// Fetches, and schedules, tests that execute _after_ the engine is built. | ||
| /// | ||
| /// If [skipEngine] is `true`, engine tests are not scheduled (it is |
Member
There was a problem hiding this comment.
s/engine tests/post engine tests/
jtmcdole
approved these changes
Feb 26, 2025
Contributor
Author
|
Moving to draft, we need to cleanup/replace |
Contributor
Author
|
@jtmcdole Updated after your refactor. |
jtmcdole
approved these changes
Feb 27, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 4, 2025
…ion flow (#164513) Closes #164030. Closes #164315. Towards #163896. Significantly simplified! We removed: - Conditional checks for monorepo (it's always a monorepo) - Conditional checks for `LUCI_CONTEXT` (LUCI takes care of itself now, see flutter/cocoon#4261) - ... and made the branching logic easier to follow as a result You can see the results first hand in the tests, which are now much simpler. Canonical docs: https://github.com/flutter/flutter/blob/master/docs/tool/Engine-artifacts.md.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes flutter/flutter#164031.