Ktlint in cipd #3522
Ktlint in cipd #3522
Conversation
…utter-hackers membership status matters, not 'you'
|
Hey @godofredoc , follow up to internal discussion (took me longer to get to this than expected). Does this look roughly correct? Does it matter where the file goes after it is downloaded by |
The upload happens in recipes (via a bot) to upload the |
| cipd_packages/device_doctor/** @yusuf-goog | ||
| cipd_packages/doxygen/** @gspencergoog | ||
| cipd_packages/ruby/** @godofredoc | ||
| cipd_packages/ktlint/** @gmackall |
There was a problem hiding this comment.
Nit: order alphabetically.
| - cipd_packages/ruby/** | ||
| - .ci.yaml | ||
|
|
||
| - name: Linux ktlint |
There was a problem hiding this comment.
Do you need one for other platforms?
There was a problem hiding this comment.
No, I only plan to use this for one of the linux checks
…aded (#3529) More context: #3522 (comment)
There was a problem hiding this comment.
Unrelated to the rest of this PR, but I noticed that this file wasn't displaying properly on github because it didn't have an .md extension, so I changed it.
In #3522 I landed a `build.sh` which uses `curl` with the output ``` -o $DIR/../build/ktlint/ ``` I didn't know `-o` is intended to target the output file, not directory (both the file and the directory in this case are named ktlint). Hence the warning: ``` Warning: Failed to create the file Warning: /b/s/w/ir/x/w/cocoon/cipd_packages/ktlint/tools/../build/ktlint: Is a Warning: directory ``` Changes to `-o $DIR/../build/ktlint/ktlint`
In flutter#3522 I landed a `build.sh` which uses `curl` with the output ``` -o $DIR/../build/ktlint/ ``` I didn't know `-o` is intended to target the output file, not directory (both the file and the directory in this case are named ktlint). Hence the warning: ``` Warning: Failed to create the file Warning: /b/s/w/ir/x/w/cocoon/cipd_packages/ktlint/tools/../build/ktlint: Is a Warning: directory ``` Changes to `-o $DIR/../build/ktlint/ktlint`
Creates a ktlint cipd package, for use in flutter/flutter#143478.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.