Skip to content

Conversation

@CaseyHillers
Copy link
Contributor

Occasionally bugs come in where targets should run, but the runIf is missing critical files (like ci.yaml). Adding this assertion here, and will update the downstream ci.yamls to be fixed.

Fixed the integration test to use the ci_yaml.dart validation suite.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read the [Flutter Style Guide] recently, and have followed its advice.
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auto-submit bot pushed a commit to flutter/engine that referenced this pull request Dec 11, 2023
@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App. label Dec 12, 2023
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App. label Dec 12, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 12, 2023

auto label is removed for flutter/cocoon/3333, due to - The status or check suite Linux Cocoon has failed. Please fix the issues identified (or deflake) before re-applying this label.

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App. label Dec 12, 2023
@auto-submit auto-submit bot merged commit 61aee79 into flutter:main Dec 12, 2023
@CaseyHillers CaseyHillers deleted the assert-runifs branch December 13, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants