-
Notifications
You must be signed in to change notification settings - Fork 100
[scheduler] Add recipe property to support releases #3305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
keyonghan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
An automated cherry pick for this PR was attempted due to the cherry pick label added. However, the cherry pick failed (potentially due to a merge confclit). You will need to create the cherry pick PR pull request manually and add chillers as a reviewer. |
|
An automated cherry pick for this PR was attempted due to the cherry pick label added. |
4 similar comments
|
An automated cherry pick for this PR was attempted due to the cherry pick label added. |
|
An automated cherry pick for this PR was attempted due to the cherry pick label added. |
|
An automated cherry pick for this PR was attempted due to the cherry pick label added. |
|
An automated cherry pick for this PR was attempted due to the cherry pick label added. |
|
An automated cherry pick for this PR was attempted due to the cherry pick label added. |
1 similar comment
|
An automated cherry pick for this PR was attempted due to the cherry pick label added. |
**design doc: go/easy-cp** umbrella design doc: go/flutter-actions umbrella bug: #139604 **Sample Results**: 1. If cherry pick succeeds, a pull request with cherry pick template and label is created. #139523 2. If cherry pick fails, a comment is added under the original Pull Request. flutter/cocoon#3305 In tests, [7d9010](7d9010c) was used to simulate a clean cherry pick, and [cf71a5](cf71a55) was used to simulate a merge conflict during cherry pick. **Implementation Details:** 1. triggered when 'cp: beta' or 'cp:stable' label is added to the original PR 4. parses release channel and gets release candidate branch name 5. get commit sha from event payload 6. checks out framework repo and revision history 7. Attempt a cherry pick without any resolution strategy 8. If cp is successful, uses a PR template to open a pull request. 9. If cp isn't successful, leave a comment on the original PR. **PR template** Since PR template doesn't support web form, the cherry pick PR template we used is https://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/template/cherrypick.md, which is adapted from the [web form cherry pick issue template](https://cs.opensource.google/flutter/flutter/+/master:.github/ISSUE_TEMPLATE/7_cherry_pick.yml). This PR template should be reviewed and added to be under the .github path in framework repository. **Decisions Taken** 1. place of source code I put the source code under the framework repository. Acknowledges the risk of duplication of code, in favor of not needing to package and publish our own actions to market place. more details in [open discussions section of design doc](https://docs.google.com/document/d/1EUyJ9NCAltxJq3P3pIzIRVF2ArPUO4cj_eqIUvzl8cw/edit#heading=h.e3zrsz9gwxmp) 2. Resolution strategy No resolution strategy is applied at all during the cherry pick process. [more details](https://docs.google.com/document/d/1EUyJ9NCAltxJq3P3pIzIRVF2ArPUO4cj_eqIUvzl8cw/edit#heading=h.3za1b9qx6pi2) **Future Work** A PAT token is needed for authorization to create branch and add comment. We would need to create a new bot and update its credentials in the secrets section of flutter/flutter repository.
|
Failed to create CP due to merge conflicts. |
|
Failed to create CP due to merge conflicts. |
2 similar comments
|
Failed to create CP due to merge conflicts. |
|
Failed to create CP due to merge conflicts. |
Fixes flutter/flutter#139313
Pre-launch Checklist
///).