Fix test ownership test to use task_name if target is a devicelab target #2898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
reviewed
Jun 29, 2023
8 tasks
keyonghan
reviewed
Jun 30, 2023
Comment on lines
+44
to
+48
| String getTestNameFromTargetName(String targetName) { | ||
| // The builder names is in the format '<platform> <test name>'. | ||
| final List<String> words = targetName.split(' '); | ||
| return words.length < 2 ? words[0] : words[1]; | ||
| } |
Contributor
There was a problem hiding this comment.
Shall we remove this function?
Contributor
Author
There was a problem hiding this comment.
I do believe that we still need this for the non devicelab tests as they still use the target name to split.
app_dart/lib/src/request_handlers/update_existing_flaky_issues.dart
Outdated
Show resolved
Hide resolved
202dfa1 to
407d35c
Compare
keyonghan
approved these changes
Jun 30, 2023
Contributor
keyonghan
left a comment
There was a problem hiding this comment.
LGTM.
You need to wait for the flutter PR to land first to unblock the CQ here.
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 30, 2023
Update a few of the tasks that are mislabeled as this will cause failures if that change is merged first. This PR is needed before: flutter/cocoon#2898 *List which issues are fixed by this PR. You must list at least one issue.* Part of #125328 *If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Contributor
|
auto label is removed for flutter/cocoon, pr: 2898, due to - This commit is not mergeable and has conflicts. Please rebase your PR and fix all the conflicts. |
6e0b1d5 to
7a1cd38
Compare
7d16b29 to
01178b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the test ownership test to compare the task_name with the dart file store in the TESTOWNERs file.
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#125328
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.