Do not enforce flutter-gold checks on auto roller authored pull requests #2585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0555407.
keyonghan
reviewed
Apr 3, 2023
| final String? name = status.context; | ||
|
|
||
| // If the account author is a roller account do not block merge on flutter-gold check. | ||
| if (config.rollerAccounts.contains(author.login!) && slug == Config.engineSlug && name == 'flutter-gold') { |
Contributor
There was a problem hiding this comment.
@zanderso Do we want to apply the rule to only skia/dart rollers, or to all rollers including the dependabot for bumping dependencies?
Member
There was a problem hiding this comment.
If possible, yeah, dependabot should also not be blocked on skia gold diffs.
keyonghan
approved these changes
Apr 3, 2023
Contributor
keyonghan
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the quick fix!
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
Closes flutter/flutter#143352. In practice this reverts the functionality in flutter/flutter#123979 (#2585). Sorry for the back-and-forth, we tried this model but ended up with (currently) [~170 untriaged failures](https://flutter-engine-gold.skia.org/), so we want to go back to treating these as failures and improve our tools/process if needed instead. /cc @jonahwilliams and @Piinks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an autoroller account generates a pull request, we do not need for it to wait for the flutter-gold status check.
List which issues are fixed by this PR. You must list at least one issue.
Fixes flutter/flutter#123979
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.