This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Use xcrun to discover Apple SDK paths #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45cdbbe to
7d94ab5
Compare
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Oct 11, 2024
7d94ab5 to
992e962
Compare
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Oct 11, 2024
77e6278 to
de7162c
Compare
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Oct 11, 2024
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Oct 11, 2024
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Oct 11, 2024
de7162c to
b008c6e
Compare
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Oct 11, 2024
b008c6e to
17e20e5
Compare
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Oct 11, 2024
jmagman
reviewed
Oct 11, 2024
build/config/ios/ios_sdk.py
Outdated
| sdk_output = run_command_with_retry(command, timeout=300) | ||
| if args.xcode is not None: | ||
| if sdk in ['iphoneos']: | ||
| sdk_output = os.path.join(args.xcode, 'iPhoneOS.platform/Developer/SDKs/iPhoneOS17.0.sdk') |
Member
There was a problem hiding this comment.
I really don't want the version hardcoded since this is coming from the Xcode sdk version in the .ci.yaml.
Can we try swapping the ios_sdk and mac_sdk python script to xcrun --sdk <sdk> --show-sdk-path instead, and see if it still times out?
Member
Author
There was a problem hiding this comment.
I agree, and I'll try that, yeah.
17e20e5 to
d1dc0e9
Compare
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Oct 11, 2024
Member
Author
|
@jmagman flutter/engine#55818 is all green, so I think this is working. |
jmagman
approved these changes
Oct 12, 2024
Member
jmagman
left a comment
There was a problem hiding this comment.
Cross referencing with flutter/flutter#94513 re: the first attempt to use hard-coded strings.
LGTM, thank you, @zanderso!
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Oct 12, 2024
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Oct 12, 2024
This change switches from using `xcodebuild` to `xcrun` for discovering the paths of installed Apple SDKs. `xcrun` tries reading this information from a cache first, which may help avoid timeouts in CI. Related flutter/flutter#155106
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 12, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Oct 12, 2024
flutter/engine@b39fec6...ea311c9 2024-10-12 zanderso@users.noreply.github.com Roll buildroot for flutter/buildroot#912 (flutter/engine#55818) 2024-10-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (#55838)" (flutter/engine#55850) 2024-10-12 flar@google.com Delete last usages of MockCanvas test mechanism (flutter/engine#55840) 2024-10-12 skia-flutter-autoroll@skia.org Roll Skia from 97cebfb06139 to d2833b68c8c7 (9 revisions) (flutter/engine#55846) 2024-10-12 jonahwilliams@google.com [Impeller] delete a bunch of dead filter code. (flutter/engine#55841) 2024-10-12 55750689+AthulJoseph27@users.noreply.github.com [Impeller] Added support to set polygon mode in Flutter GPU. (flutter/engine#55804) 2024-10-11 skia-flutter-autoroll@skia.org Manual roll Dart SDK from d916a5f69a48 to 75bf9e183a33 (1 revision) (flutter/engine#55838) 2024-10-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1OZ2rHDklRNSZRUrc... to tNuwSyjjbdU9HjOwQ... (flutter/engine#55837) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 1OZ2rHDklRNS to tNuwSyjjbdU9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC jacksongardner@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
This change switches from using `xcodebuild` to `xcrun` for discovering the paths of installed Apple SDKs. `xcrun` tries reading this information from a cache first, which may help avoid timeouts in CI. Related flutter#155106
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested in flutter/engine#55818