This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Simplify GN pools, use for some toolchain actions #856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
May 10, 2024
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
May 10, 2024
This PR changes from using a different GN pool for each non-compiler tool, to using one GN pool for everything. Additionally, since we are no longer linking remotely in any configuration, this PR uses the pool for linking. ObjC and impellerc tasks also do not (yet) run on RBE, so they are also now governed by the pool. Needs flutter/buildroot#856
eyebrowsoffire
pushed a commit
that referenced
this pull request
Jun 27, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to flutter/engine#52721