This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Change location of emsdk. #833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
approved these changes
Mar 9, 2024
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Mar 11, 2024
This migrates the emscripten toolchain into the flutter repo, as well as the fonts for web unit tests. Also, removed the `web_dependencies` thing which is no longer used. This fixes flutter/flutter#143332 Depends on a buildroot change here: flutter/buildroot#833
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Mar 11, 2024
…51299)" (#51330) Reverts: #51299 Initiated by: zanderso Reason for reverting: Blocking the autoroller Original PR Author: eyebrowsoffire Reviewed By: {matanlurey} This change reverts the following previous change: This migrates the emscripten toolchain into the flutter repo, as well as the fonts for web unit tests. Also, removed the `web_dependencies` thing which is no longer used. This fixes flutter/flutter#143332 Depends on a buildroot change here: flutter/buildroot#833
Contributor
|
A reason for requesting a revert of flutter/buildroot/833 could |
Contributor
Author
|
Reason for revert: corresponding change flutter/engine@6cefbe1 was reverted |
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 12, 2024
This reverts commit b1fdfb2.
auto-submit bot
added a commit
that referenced
this pull request
Mar 12, 2024
Reverts: #833 Initiated by: eyebrowsoffire Reason for reverting: corresponding change flutter/engine@6cefbe1 was reverted Original PR Author: eyebrowsoffire Reviewed By: {matanlurey} This change reverts the following previous change: This changes the location the build files look for the emscripten toolchain. It is meant to go in alongside flutter/engine#51299 which actually changes the DEPS file to place emsdk in a different place.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the location the build files look for the emscripten toolchain. It is meant to go in alongside flutter/engine#51299 which actually changes the DEPS file to place emsdk in a different place.