This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Move Abseil to flutter/third_party/abseil-cpp #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In combination with https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848, this updates Flutter's references to Abseil from //third_party/abseil-cpp to //flutter/third_party/abseil-cpp. Issue: flutter/flutter#144201 Part of: flutter/flutter#67373
matanlurey
approved these changes
Mar 6, 2024
9 tasks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Mar 7, 2024
In combination with: * https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848 * flutter/buildroot#831 this updates Flutter's references to Abseil from //third_party/abseil-cpp to //flutter/third_party/abseil-cpp. Issue: flutter/flutter#144201 Part of: flutter/flutter#67373 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In combination with
https://flutter-review.googlesource.com/c/third_party/abseil-cpp/+/55848, this updates Flutter's references to Abseil from
//third_party/abseil-cpp to //flutter/third_party/abseil-cpp.
Will be followed by a DEPS roll in flutter/engine and patches to our own BUILD.gn files and #includes.
Issue: flutter/flutter#144201
Part of: flutter/flutter#67373
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.