This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Add FIDL HLCPP tables.c file to the build #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I changed it so that it will work both before and after the roll. |
This is a continuation of flutter#795. This tables.c file is currently empty, but we will migrate the fidlc coding tables to it. See https://fxrev.dev/953989 for the full soft transition plan.
jrwang
approved these changes
Dec 7, 2023
mk12
added a commit
to mk12/buildroot
that referenced
this pull request
Jan 26, 2024
Now that flutter#798 added the new tables.c file, and https://fxrev.dev/946309 moved the content from the old file to the new file, we can stop generating the old file (i.e. stop passing --tables to fidlc). See https://fxbug.dev/42115242 for context.
mk12
added a commit
that referenced
this pull request
Jan 29, 2024
Now that #798 added the new tables.c file, and https://fxrev.dev/946309 moved the content from the old file to the new file, we can stop generating the old file (i.e. stop passing --tables to fidlc). See https://fxbug.dev/42115242 for context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #795. This tables.c file is currently empty, but we will migrate the fidlc coding tables to it. See https://fxrev.dev/953989 for the full soft transition plan.