Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 30, 2022

xcodebuild -showsdks -json is returning the same sdkVersion for different sdkPaths on > Xcode 14

  {
    "canonicalName" : "macosx13.0",
...
    "sdkPath" : "/Users/m/Applications/Xcode-14-1_beta3.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.sdk",
    "sdkVersion" : "13.0"
  },
  {
    "canonicalName" : "macosx13.0",
...
    "sdkPath" : "/Users/m/Applications/Xcode-14-1_beta3.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.0.sdk",
    "sdkVersion" : "13.0"
  },

The order it's returning these isn't stable, so it keeps swapping which path is listed last on different runs which is causing -isysroot to be different between ninja runs, which is unnecessaryly dirtying and causing huge recompiles.

Sort the SDKs returned by xcodebuild -showsdks so that duplicated sdkVersions mapped to different paths always chooses the same path between runs.

Fixes flutter/flutter#112928

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 30, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 30, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Nov 30, 2022

auto label is removed for flutter/buildroot, pr: 652, Failed to merge pr#: 652 with Pull request could not be merged: Resource not accessible by integration.

@jmagman
Copy link
Member Author

jmagman commented Nov 30, 2022

Merging manually.
flutter/flutter#116304

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Xcode14 will recompile a lot of files even not change any files.

2 participants