Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Build arm iOS simulator with Fuchsia toolchain and not Xcode #636

Merged
jmagman merged 1 commit into from
Oct 6, 2022
Merged

Build arm iOS simulator with Fuchsia toolchain and not Xcode #636

jmagman merged 1 commit into from
Oct 6, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Oct 6, 2022 •
edited
Loading

The Fuchsia toolchain version of clang (version 16.0.0) happily builds and runs --simulator-cpu=arm64 on this patch.

$ ./flutter/tools/gn --no-goma --ios --simulator --unoptimized  --simulator-cpu=arm64 && ninja -C out/ios_debug_sim_unopt_arm64

$ flutter run --local-engine ios_debug_sim_unopt_arm64

Screen Shot 2022-10-05 at 6 48 54 PM

Will remove engine usage during roll:
https://github.com/flutter/engine/blob/1c232b584c57fcb43dadc1602b4b202ace80645a/BUILD.gn#L36

Fixes flutter/flutter#112992

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Oct 6, 2022
jmagman
jmagman commented Oct 6, 2022
View reviewed changes
build/config/compiler/BUILD.gn
}

if (!use_xcode) {
default_warning_flags += [
Copy link
Member Author

@jmagman jmagman Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of this hunk is all whitespace changes.

@jmagman jmagman requested review from cbracken and zanderso October 6, 2022 00:05
cbracken
cbracken approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@jmagman jmagman merged commit 2fd45de into flutter:master Oct 6, 2022
@jmagman jmagman deleted the arm-simulator branch October 6, 2022 01:52
@jmagman jmagman mentioned this pull request Oct 6, 2022
Merged
stuartmorgan-g added a commit to stuartmorgan-g/buildroot that referenced this pull request Sep 6, 2023
@stuartmorgan-g
Revert "Build arm iOS simulator with Fuchsia toolchain and not Xcode (f…
520d9ab 
…lutter#636)"

This reverts commit 2fd45de.
@jmagman jmagman mentioned this pull request Aug 5, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso Awaiting requested review from zanderso

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build all iOS build variants on the Fuchsia toolchain and not Xcode

2 participants

@jmagman @cbracken