This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Re-land vpython3 in .gn from depot_tools #590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
approved these changes
Jul 25, 2022
Member
cbracken
left a comment
There was a problem hiding this comment.
LGTM! Make sure you've tested locally before landing to save you the engine roll if not. :)
8 tasks
This was referenced Jul 27, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6ef1bf7.
Rolling the revert in #507 breaks the Fuchsia build, which requires a Python 3 distribution that includes the yaml module. Instead, @cbracken landed flutter/engine#28314, which enables vpython3 for runs of the gn wrapper on Windows, via the gn.bat batch script. That seems to have eliminated the flakiness we were seeing on the engine Windows bots.
Issue: flutter/flutter#88719
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.