Skip to content
This repository was archived by the owner on Apr 21, 2025. It is now read-only.

Conversation

@cbracken
Copy link
Member

This removes a script that was used to generate C++ WinRT headers using
cppwinrt. All uses of these headers was removed with the removal of the
UWP embedder in:
flutter/engine#33019

and removal of the gclient hook in:
flutter/engine#33030

Issue: flutter/flutter#102172

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This removes a script that was used to generate C++ WinRT headers using
cppwinrt. All uses of these headers was removed with the removal of the
UWP embedder in:
flutter/engine#33019

and removal of the gclient hook in:
flutter/engine#33030

Issue: flutter/flutter#102172
Copy link

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken merged commit 63f03c8 into flutter:master Apr 30, 2022
@cbracken cbracken deleted the remove-gen-winrt-headers branch April 30, 2022 18:59
cbracken added a commit to flutter/engine that referenced this pull request Apr 30, 2022
This includes:
* Win: Remove generate_winrt_headers.py (flutter/buildroot#568)

Issue: flutter/flutter#102172
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants