This repository was archived by the owner on Apr 21, 2025. It is now read-only.
[win32] Use clang cflags on Windows builds #561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we're now using the clang toolchain for engine builds, use the same set of warning cflags on Windows as we do on macOS, Linux. Issue: flutter/flutter#59199
jason-simmons
approved these changes
Apr 13, 2022
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're now using the clang toolchain for engine builds, use the
same set of warning cflags on Windows as we do on macOS, Linux.
This significantly reduces the set of compiler warning spam on Windows
builds.
Issue: flutter/flutter#59199
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.