This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Support iOS ARM64 simulator builds #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
reviewed
Jun 18, 2021
cbracken
approved these changes
Jun 18, 2021
15abc58 to
6fbd71b
Compare
richkadel
pushed a commit
to richkadel/buildroot
that referenced
this pull request
Jun 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#84670
This was previously landed and backed out for this failure: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20iOS%20Engine%20Release/7004/overview
I have done a full CI pre-submit run here: flutter/engine#26784 and manually triggered a
Mac iOS Engine Releaserun here: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/wrightgeorge_google.com/714c2f7d1c809fcbdd78d87e13fe2665d166438b0676ac67ea88cde200e6ff6e/+/build.protoBoth are passing (with the exception of failing to upload artifacts, due to being run on a try job), so I think we can merge this now.