This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Fix visibility of symbols of libcxxabi #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Contributor
|
Verified locally that this solves flutter/flutter#74599. |
stuartmorgan-g
approved these changes
Jan 27, 2021
Contributor
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM, thanks for the PR!
stuartmorgan-g
added a commit
to flutter/engine
that referenced
this pull request
Jan 27, 2021
9 tasks
stuartmorgan-g
added a commit
to flutter/engine
that referenced
this pull request
Jan 28, 2021
stuartmorgan-g
pushed a commit
that referenced
this pull request
Jan 28, 2021
This reverts commit 33f05b6.
stuartmorgan-g
added a commit
that referenced
this pull request
Jan 28, 2021
hjfreyer
pushed a commit
to hjfreyer/engine
that referenced
this pull request
Mar 22, 2021
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time we cannot throw and catch C++ exceptions in plugin platform code. Because Flutter statically links libcxx and libcxxabi which exposes symbols like __cxa_decrement_exception_refcount, which will introduce two versions of cxxabi functions, throwing libcxx exceptions, and catching them by libstdc++ method.
To fix this problem, this PR set
__LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONSto suppress symbol leaks, which is tested and worked correctly. All platforms artifacts will get benefit from this pr.This pull request fixes issue flutter/flutter#66575 and flutter/flutter#74599.