This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Make symlinks so that RBE will work for Xcode toolchains #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Do the symlinks need to go in a .gitignore? |
Contributor
Author
|
They're created in a generated out directory - e.g. |
zanderso
reviewed
Dec 11, 2020
build/mac/find_sdk.py
Outdated
| from optparse import OptionParser | ||
|
|
||
|
|
||
| def mkdir_p(path): |
Member
There was a problem hiding this comment.
Is there any way to avoid copying this to several places?
Contributor
Author
There was a problem hiding this comment.
Yeah. I also realize that I need to fix this so it replaces the symlink incase you e.g. update or move Xcode for some reason.
zanderso
approved these changes
Dec 11, 2020
|
|
||
| import errno | ||
| import os | ||
|
|
dnfield
added a commit
to flutter/engine
that referenced
this pull request
Dec 11, 2020
See flutter/buildroot#417 This helps make GOMA work on macOS related builds.
dnfield
added a commit
to flutter/engine
that referenced
this pull request
Dec 15, 2020
* Roll buildroot to flutter/buildroot@64bf320 See flutter/buildroot#417 This helps make GOMA work on macOS related builds.
gspencergoog
pushed a commit
to gspencergoog/engine
that referenced
this pull request
Jan 5, 2021
* Roll buildroot to flutter/buildroot@64bf320 See flutter/buildroot#417 This helps make GOMA work on macOS related builds.
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See flutter/flutter#72032
This creates symlinks for the macOS SDK, iPhone SDK, and Xcode toolchain sysroot in the gen dir. That way, RBE won't fail when it tries to access a file based on an absolute path to /Applications/whatever on mac based host/iOS builds.