This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Reland: Add support for ANGLE using upstream build rules #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds minimal (in some cases dummy) files sufficient to allow building ANGLE in this buildroot using the build_with_chromium option. This relanded version uses the new swiftshader_ prefixed versions of the DLL names in the swiftshader build, which are loaded preferentially if available. This ensures that the swiftshader tests will use those, rather than the potentially incompatible ANGLE versions. In local testing, this resolved the ShellTest failures that led to the previous revert.
Contributor
Author
|
Once this lands I'll roll it into the engine right away so that I can roll it back if there are still problems, before it affects other buildroot PRs. |
chinmaygarde
approved these changes
Aug 8, 2019
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
This adds minimal (in some cases dummy) files sufficient to allow building ANGLE in this buildroot using the build_with_chromium option. This relanded version uses the new swiftshader_ prefixed versions of the DLL names in the swiftshader build, which are loaded preferentially if available. This ensures that the swiftshader tests will use those, rather than the potentially incompatible ANGLE versions. In local testing, this resolved the ShellTest failures that led to the previous revert.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds minimal (in some cases dummy) files sufficient to allow
building ANGLE in this buildroot using the build_with_chromium
option.
This relanded version uses the new swiftshader_ prefixed versions of the
DLL names in the swiftshader build, which are loaded preferentially if
available. This ensures that the swiftshader tests will use those,
rather than the potentially incompatible ANGLE versions. In local
testing, this resolved the ShellTest failures that led to the previous
revert.