This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Add support for ANGLE using upstream build rules #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds minimial (in some cases dummy) files sufficient to allow building ANGLE in this buildroot using the build_with_chromium option.
Contributor
Author
|
FYI @clarkezone |
chinmaygarde
approved these changes
Jul 18, 2019
build/config/dcheck_always_on.gni
Outdated
| # Enables DCHECKs to be built-in, but to default to being non-fatal/log-only. | ||
| # DCHECKS can then be set as fatal/non-fatal via the DCheckIsFatal feature. | ||
| # See crbug.com/596231 for details on how this is used. | ||
| dcheck_is_configurable = false |
Contributor
There was a problem hiding this comment.
This does nothing in our buildroot. Let's always set both to false.
Contributor
Author
There was a problem hiding this comment.
Updated to make this always false. I'm leaving dcheck_always_on in a declare_args since it was already an argument before the patch, and I'd rather not have potential fallout from removing an argument as part of this patch.
| use_prebuilt_instrumented_libraries = false | ||
| } | ||
|
|
||
| use_fuzzing_engine = false |
Contributor
There was a problem hiding this comment.
Shouldn't this go in the declare_args block?
Contributor
Author
There was a problem hiding this comment.
true isn't supported without more buildroot work, so it can't be an argument in our build at this point. If someone wants to make it an argument, they'll need to do follow-up work.
chinmaygarde
approved these changes
Jul 18, 2019
iskakaushik
pushed a commit
to iskakaushik/buildroot
that referenced
this pull request
Jul 30, 2019
This reverts commit fe3b828.
iskakaushik
added a commit
that referenced
this pull request
Jul 30, 2019
stuartmorgan-g
added a commit
that referenced
this pull request
Aug 6, 2019
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
This adds minimial (in some cases dummy) files sufficient to allow building ANGLE in this buildroot using the build_with_chromium option.
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
…" (flutter#285) This reverts commit fe3b828.
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
Reland of fe3b828 (flutter#276) This adds minimal (in some cases dummy) files sufficient to allow building ANGLE in this buildroot using the build_with_chromium option.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds just enough changes from the Chromium build infrastructure that have happened since buildroot was first forked off from it to allow building ANGLE on Windows using the upstream ANGLE BUILD.gn files in 'build_with_chromium' mode.
This is needed in order to add ANGLE for the upcoming move away from GLFW for the Windows embedding.