This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Update vcvarsall.bat location with vs2017 #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes one issue of building engine on non-corp windows machines.
dnfield
approved these changes
Apr 2, 2019
liyuqian
added a commit
to liyuqian/engine
that referenced
this pull request
Apr 3, 2019
This includes flutter/buildroot#228
liyuqian
added a commit
to flutter/engine
that referenced
this pull request
Apr 3, 2019
This includes flutter/buildroot#228
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This includes flutter/buildroot#228
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes one issue of building engine on non-corp windows machines.
This seems to be a difference between vs2015 and vs2017. See https://social.msdn.microsoft.com/Forums/en-US/1071be0e-2a46-4c30-9546-ea9d7c4755fa/where-is-vcvarsallbat-file?forum=visualstudiogeneral for more details.