Move tx-queue/acquire-lock call to process-transactions#22
Merged
cap10morgan merged 1 commit intomainfrom Nov 21, 2023
Merged
Conversation
The expected args aren't available where it was being called before.
Contributor
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
Merged
dpetran
reviewed
Nov 21, 2023
| ;; TODO - push-consensus will only work if a leader. As leader can only do txns for the moment this is OK | ||
| ;; TODO - but once the work gets spread out to other servers it will have to push the commit to the leader | ||
| (let [processed* (conj processed tx-id)] | ||
| (when (acquire-lock ledger-id tx-id) |
Contributor
There was a problem hiding this comment.
What happens to the queue when the lock can't be acquired?
I'd guess it means that some other server has the lock, but how can that be if this ledger is my-responsibility? Does the queue just not get processed then?
Contributor
Author
There was a problem hiding this comment.
I'm not sure, to be honest. But where it was being called before if the lock acquisition failed it wouldn't even call this fn, which I think is basically the same behavior it has now.
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected args aren't available where it was being called before.
Fixes https://github.com/fluree/core/issues/64