add support for application/sparql-update transaction requests#126
Merged
add support for application/sparql-update transaction requests#126
Conversation
In lieu of pushing down sparql translation to the `db` api, this PR just translates the SPARQL update into fql at the first opportunity in order to minimize structural changes to transaction processing which depends on txn introspection.
f739aa8 to
e2946b2
Compare
zonotope
approved these changes
Mar 21, 2025
| {:keys [body]} :parameters}] | ||
| (let [txn-context (ctx-util/txn-context body) | ||
| ledger-id (transact-api/extract-ledger-id body)] | ||
| (let [txn (if (= :sparql (:format opts)) |
Contributor
There was a problem hiding this comment.
I think you should use the function you just defined in db here.
Also, maybe not for this pr, but I think we should eventually write a function that can extract the ledger id directly from a sparql query, or move all sparql conversion outside of the db library here. (This is just a gut level thought. I haven't thought through all of the implications yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the SPARQL Protocol update operation.
In lieu of pushing down sparql translation to the
dbapi, this PR just translates the SPARQL update into fql at the first opportunity in order to minimize structural changes to transaction processing which depends on txn introspection.Depends on fluree/db#992
https://github.com/fluree/core/issues/175