Conversation
Contributor
Author
|
Converting to draft while I add the bits necessary to integrate with server. |
WITH and USING are not allowed in an INSERT/DELETE DATA clause, so we need to allow exactly one GRAPH pattern.
Contributor
Author
|
This is now ready for review with all the server bits finished. |
zonotope
approved these changes
Mar 21, 2025
src/fluree/db/api/transact.cljc
Outdated
| parsed-opts (parse-opts txn opts txn-context) | ||
| parsed-txn (q-parse/parse-txn txn txn-context)] | ||
| (<? (connection/stage-triples db parsed-txn parsed-opts))))) | ||
| (let [txn* (if (= :sparql (:format opts)) |
Contributor
There was a problem hiding this comment.
i think it makes sense to convert this check into a function that takes the transaction and the format since it's used multiple times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for SPARQL Graph Update syntax: https://www.w3.org/TR/2013/REC-sparql11-update-20130321/#graphUpdate
Since we only allow transacting to a single ledger at a time, we do not support GRAPH patterns or multiple USING/USING NAMED clauses.
https://github.com/fluree/core/issues/175