Conversation
It uses the "https://flur.ee" string as the key as that's the shortest possible one, but we can change that in the future if we need to - the IRIs all expand to "https://flur.ee/ns/<term>" regardless.
bef0bf6 to
806408c
Compare
7a1bcd0 to
2be5f54
Compare
2198a13 to
2b4a4cf
Compare
This was referenced Oct 24, 2023
cap10morgan
approved these changes
Oct 24, 2023
Contributor
cap10morgan
left a comment
There was a problem hiding this comment.
Question about the meaning of a new docstring, but looks good o/w!
| [fluree.json-ld.impl.external :as external])) | ||
|
|
||
| (defn pluggable-loader | ||
| "Takes a document-loader, which takes a url and options and returns a json string |
Contributor
There was a problem hiding this comment.
Is this missing a conclusion or a comma? In other words, does "and returns a json string..." apply to the document-loader (in which case this is missing a conclusion about what the fn itself returns / does) or to the fn itself (in which case this is missing a comma between "and options" and "and returns" (or you could wrap "which takes a url and options" in parens).
Contributor
Author
There was a problem hiding this comment.
I see how that's confusing! I tried rewriting it a few times and then decided to just document the argument explicitly, I think it's an improvement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for a new fluree vocabulary for https://github.com/fluree/core/issues/27
This builds off of the language tags branch as that has updated structure for #25.