Conversation
dpetran
left a comment
There was a problem hiding this comment.
This looks great, and I love aligning our expand with how a compliant json-ld processor expand works.
What's the strategy for including it into db? I know it will take some extra work, but merging this onto main before that work is done makes me feel a little leery, though I don't really know why, since all we have to do is not update db's json-ld dep until we're ready.
I'm working on the db side now, and I wasn't planning on merging this into main until that was ready too. I think your leeriness is well-founded. If someone needs to make a quick change here in the intervening time, we'll either have to wait on that or back out these changes until the db work I'm doing now is ready. I'll keep this branch up to date and merge everything once the db side of language tags is done. |
This patch adds support for expanding language tagged strings. Because multiple values of the same property can exist with different language tags, this patch also changes the shape of expanded nodes to ensure that all property values are expanded into a collection (except for @id because it must be unique). Otherwise, only one language-tagged value would have been preserved after expansion.