Skip to content

Conversation

@zmrlft
Copy link
Collaborator

@zmrlft zmrlft commented Oct 6, 2025

Ⅰ. Describe what this PR does

Fixes high-severity vulnerability in path-to-regexp (GHSA-9wv6-86v2-598j)(CVE-2024-45296) via dependency resolution:

  • in resolutions in package.json to force path-to-regexp@^3.3.0 for:
    • **/@ks-console/server/path-to-regexp
    • **/@ks-console/shared/path-to-regexp

Ⅱ. Does this pull request fix one issue?

fixes path-to-regexp outputs backtracking regular expressions (GHSA-9wv6-86v2-598j)(CVE-2024-45296)

Ⅲ. List the added test cases

None. This is a dependency resolution fix with no code changes.

Ⅳ. Describe how to verify it

  1. Check out branch and run yarn install
  2. Verify version: yarn why path-to-regexp should show ^3.3.0 for the affected dependencies(@ks-console/server and @ks-console/shared)
  3. Run yarn audit to check if there is this vulnerability. Then run yarn dev to confirm that it operates normally.

Ⅴ. Special notes for reviews

… vulnerability

Signed-off-by: zmrlft <2643895326@qq.com>
@zmrlft zmrlft force-pushed the fix/dashboard-ks-extension-path-to-regexp-vulnerability branch from bc73f51 to 8aacbd0 Compare October 6, 2025 07:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2025

@codecov
Copy link

codecov bot commented Oct 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.70%. Comparing base (e74379d) to head (8aacbd0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5272   +/-   ##
=======================================
  Coverage   56.70%   56.70%           
=======================================
  Files         440      440           
  Lines       30369    30369           
=======================================
  Hits        17220    17220           
  Misses      11537    11537           
  Partials     1612     1612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RongGu RongGu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Oct 7, 2025
@RongGu RongGu merged commit f5a1bd0 into fluid-cloudnative:master Oct 7, 2025
15 of 16 checks passed
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Oct 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RongGu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Pikabooboo pushed a commit to Pikabooboo/fluid that referenced this pull request Oct 8, 2025
… vulnerability (fluid-cloudnative#5272)

Signed-off-by: zmrlft <2643895326@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants