optim: trim descriptions in fluid crds to avoid touching size limit in helm release storage #5251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lm release Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5251 +/- ##
=======================================
Coverage 55.50% 55.50%
=======================================
Files 443 443
Lines 30438 30438
=======================================
Hits 16896 16896
Misses 11978 11978
Partials 1564 1564 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pikabooboo
pushed a commit
to Pikabooboo/fluid
that referenced
this pull request
Sep 25, 2025
…lm release (fluid-cloudnative#5251) Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Fluid is usually installed by Helm. When helm installs/upgrades a helm release, it generates a Kubernetes Secret resource to store all the compressed release data(including CRD specifications) in it. Kubernetes has a size limit on the stored data in a Secret resource (normally 1M). Fluid may touch the size limit when we are introducing more and more Fluid CRDs to the helm chart.
Currently, the size of the compressed data of a Fluid helm release is about 880K, which is approaching the limit (1.0M)
This PR follows common solutions proposed in community (Kubebuilder FAQ, Kubernetes#82292) to trim all descriptions in the CRD to make CRD size smaller.
After trimming all the description, we see the size of the compressed data lowers down to ~160K:
NOTE: trimming all the descriptions brings side effects:
kubectl explainwill no longer "explain" the meaning of each field. USERS should refer to Fluid's API Doc for field references.Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews