feat(ddc): adjust prefetcher version based on JindoFS image tag #5235

TrafalgarZZZ · 2025-09-15T08:07:15Z

Ⅰ. Describe what this PR does

Add logic to determine prefetcher version based on JindoFS image tag
Implement version parsing and comparison functions
Update transformFuse function to use the appropriate prefetcher version
Add unit tests for version parsing function

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

fluid-e2e-bot · 2025-09-15T08:07:22Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

codecov · 2025-09-15T08:24:12Z

Codecov Report

❌ Patch coverage is 54.23729% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.50%. Comparing base (f8fa5c3) to head (fe2eab0).
⚠️ Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/ddc/jindocache/utils.go	47.82%	15 Missing and 9 partials ⚠️
pkg/ddc/jindocache/transform.go	76.92%	1 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5235      +/-   ##
==========================================
- Coverage   55.51%   55.50%   -0.01%     
==========================================
  Files         443      443              
  Lines       30382    30438      +56     
==========================================
+ Hits        16867    16896      +29     
- Misses      11962    11978      +16     
- Partials     1553     1564      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Add logic to determine prefetcher version based on JindoFS image tag - Implement version parsing and comparison functions - Update transformFuse function to use the appropriate prefetcher version - Add unit tests for version parsing function Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

- Update smartdata image tag from 6.2.0 to 6.9.1-202509151826 - Update fuse image tag from 6.2.0 to 6.9.1-202509151826 Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

TrafalgarZZZ · 2025-09-16T03:18:10Z

/test fluid-e2e

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

TrafalgarZZZ · 2025-09-16T07:47:03Z

/retest

TrafalgarZZZ · 2025-09-16T07:52:57Z

/retest

TrafalgarZZZ · 2025-09-16T07:53:47Z

/test fluid-e2e

TrafalgarZZZ · 2025-09-16T09:36:19Z

/retest

TrafalgarZZZ · 2025-09-16T09:57:52Z

/retest

TrafalgarZZZ · 2025-09-16T11:37:48Z

/retest

TrafalgarZZZ · 2025-09-16T12:32:14Z

/retest

cheyang · 2025-09-16T13:42:04Z

/retest

cheyang · 2025-09-16T13:53:48Z

pkg/ddc/jindocache/transform.go

+
+	// Assume value.FuseImageTag has been set here
+	if len(value.FuseImageTag) != 0 {
+		fuseVersion, err := parseVersionFromImageTag(value.FuseImageTag)


Should we fail fast when
fuseVersion, err := parseVersionFromImageTag(value.FuseImageTag)
returns a non-nil error？

In that case, image tags are required to be in format of "X.Y.Z-xxxxxx". Users may change it to a customized tag.

cheyang · 2025-09-16T13:55:10Z

pkg/ddc/jindocache/utils_test.go

+		wantErr  bool
+	}{
+		{
+			name:     "valid version without tag",


How about adding test case v6.2.0?

Done. parseVersionFromImageTag now supports parsing version info from either 6.2.0 or v6.2.0.

cheyang · 2025-09-17T02:56:41Z

/test fluid-e2e

- Update regular expression to match version strings with optional 'v' prefix - Add test cases for version strings with 'v' prefix, both with and without tags Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

sonarqubecloud · 2025-09-17T03:10:55Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

TrafalgarZZZ · 2025-09-17T04:07:23Z

/test fluid-e2e

TrafalgarZZZ · 2025-09-18T02:01:44Z

/retest

cheyang

/lgtm
/approve

fluid-e2e-bot · 2025-09-18T02:23:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cheyang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…d-cloudnative#5235) * feat(ddc): adjust prefetcher version based on JindoFS image tag - Add logic to determine prefetcher version based on JindoFS image tag - Implement version parsing and comparison functions - Update transformFuse function to use the appropriate prefetcher version - Add unit tests for version parsing function Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * fix go fmt Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * fix go fmt Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * update smartdata and fuse image tags - Update smartdata image tag from 6.2.0 to 6.9.1-202509151826 - Update fuse image tag from 6.2.0 to 6.9.1-202509151826 Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * fix image prefix in gha e2e Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * enhance version parsing to support 'v' prefix - Update regular expression to match version strings with optional 'v' prefix - Add test cases for version strings with 'v' prefix, both with and without tags Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

fluid-e2e-bot bot added the do-not-merge/work-in-progress label Sep 15, 2025

TrafalgarZZZ added 3 commits September 15, 2025 16:49

fix go fmt

38944b1

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

fix go fmt

384fcb5

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

TrafalgarZZZ force-pushed the enhance/set_jindofsx_prefetcher_version_accordingly branch from dcaaa67 to 384fcb5 Compare September 15, 2025 08:49

update smartdata and fuse image tags

26362b9

- Update smartdata image tag from 6.2.0 to 6.9.1-202509151826 - Update fuse image tag from 6.2.0 to 6.9.1-202509151826 Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

TrafalgarZZZ marked this pull request as ready for review September 16, 2025 03:18

fluid-e2e-bot bot removed the do-not-merge/work-in-progress label Sep 16, 2025

fix image prefix in gha e2e

9c431bf

Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

cheyang requested a review from frankleaf September 16, 2025 13:46

cheyang reviewed Sep 16, 2025

View reviewed changes

enhance version parsing to support 'v' prefix

fe2eab0

- Update regular expression to match version strings with optional 'v' prefix - Add test cases for version strings with 'v' prefix, both with and without tags Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>

cheyang approved these changes Sep 18, 2025

View reviewed changes

fluid-e2e-bot bot assigned cheyang Sep 18, 2025

fluid-e2e-bot bot added the lgtm label Sep 18, 2025

fluid-e2e-bot bot added the approved label Sep 18, 2025

fluid-e2e-bot bot merged commit 34912e6 into fluid-cloudnative:master Sep 18, 2025
17 checks passed

feat(ddc): adjust prefetcher version based on JindoFS image tag #5235

feat(ddc): adjust prefetcher version based on JindoFS image tag #5235

Uh oh!

Conversation

TrafalgarZZZ commented Sep 15, 2025

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

fluid-e2e-bot bot commented Sep 15, 2025

Uh oh!

codecov bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

TrafalgarZZZ commented Sep 16, 2025

Uh oh!

TrafalgarZZZ commented Sep 16, 2025

Uh oh!

TrafalgarZZZ commented Sep 16, 2025

Uh oh!

TrafalgarZZZ commented Sep 16, 2025

Uh oh!

TrafalgarZZZ commented Sep 16, 2025

Uh oh!

TrafalgarZZZ commented Sep 16, 2025

Uh oh!

TrafalgarZZZ commented Sep 16, 2025

Uh oh!

TrafalgarZZZ commented Sep 16, 2025

Uh oh!

cheyang commented Sep 16, 2025

Uh oh!

cheyang Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

TrafalgarZZZ Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

cheyang Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

TrafalgarZZZ Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cheyang commented Sep 17, 2025

Uh oh!

sonarqubecloud bot commented Sep 17, 2025

Quality Gate passed

Uh oh!

TrafalgarZZZ commented Sep 17, 2025

Uh oh!

TrafalgarZZZ commented Sep 18, 2025

Uh oh!

cheyang left a comment

Choose a reason for hiding this comment

Uh oh!

fluid-e2e-bot bot commented Sep 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Sep 15, 2025 •

edited

Loading

TrafalgarZZZ Sep 17, 2025 •

edited

Loading