dataset support pvc storageSize #4178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wangshulei098. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2f0640c to
8b67eea
Compare
cheyang
requested changes
Jun 25, 2024
650163e to
23e0877
Compare
api/v1alpha1/dataset_types.go
Outdated
|
|
||
| // StorageCapacity is the storage size of generated PVC and PV | ||
| // +optional | ||
| StorageCapacity resource.Quantity `json:"storageCapacity,omitempty"` |
Member
There was a problem hiding this comment.
Do we have to add a new field to the Dataset CRD? StorageCapacity is just informational in Fluid, might be confusing with some other concept like tieredstore.quota. How about following PR#3146? So we can override storage capacity with a given annotation on Dataset? WDYT @wangshulei098 @cheyang
Collaborator
There was a problem hiding this comment.
Good point. Agree. I think we can use the annotation key pvc.fluid.io/resources.request.storageSize to specify the desired storage size for the PVC. This key is descriptive and aligns with the Kubernetes convention for resource requests.
It can provide flexibility to extend the customization of PVC.
Contributor
Author
There was a problem hiding this comment.
ok,I will change it
Contributor
Author
There was a problem hiding this comment.
we have used “pvc.fluid.io/resources.requests.storage” as the annotation key on Dataset to specify the desired storage size for the generated PVC. If not set, or if the storage size format is incorrect, it will be set to the default value of 100Pi.
23e0877 to
429b3e9
Compare
cheyang
requested changes
Jun 28, 2024
429b3e9 to
19281c4
Compare
cheyang
requested changes
Jun 28, 2024
cheyang
requested changes
Jun 28, 2024
19281c4 to
d073198
Compare
d073198 to
269b438
Compare
cheyang
requested changes
Jun 28, 2024
Signed-off-by: wangshulei098 <850732903@qq.com>
269b438 to
f332295
Compare
Collaborator
|
/test fluid-e2e |
Collaborator
|
@wangshulei098 Thanks for your contributions! @TrafalgarZZZ please also take a look. Thanks. |
TrafalgarZZZ
approved these changes
Jul 1, 2024
Member
TrafalgarZZZ
left a comment
There was a problem hiding this comment.
Thanks @wangshulei098 for supporting this! LGTM
/lgtm
Collaborator
|
@wangshulei098 Would you mind developing document for this? Thanks. It can be next PR. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang, TrafalgarZZZ The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cheyang
pushed a commit
to Ametsuji-akiya/fluid
that referenced
this pull request
Jul 16, 2024
Signed-off-by: wangshulei098 <850732903@qq.com> Signed-off-by: cheyang <cheyang@163.com>
cheyang
added a commit
to cheyang/fluid
that referenced
this pull request
Aug 12, 2024
…50932 (fluid-cloudnative#4154) Signed-off-by: cheyang <cheyang@163.com> Bump up the vineyard to v0.22.2 (fluid-cloudnative#4153) Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com> Bump github.com/agiledragon/gomonkey/v2 from 2.10.1 to 2.11.0 (fluid-cloudnative#4151) Bumps [github.com/agiledragon/gomonkey/v2](https://github.com/agiledragon/gomonkey) from 2.10.1 to 2.11.0. - [Release notes](https://github.com/agiledragon/gomonkey/releases) - [Commits](agiledragon/gomonkey@v2.10.1...v2.11.0) --- updated-dependencies: - dependency-name: github.com/agiledragon/gomonkey/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> date (fluid-cloudnative#4110) Signed-off-by: Lumen002 <1277683286@qq.com> Add apache license_format in fluid_ufs_scheme_test.go (fluid-cloudnative#4120) * Format Apache License to webhook.go Signed-off-by: mave <211220097@smail.nju.edu.cn> * Your commit message Signed-off-by: mave <211220097@smail.nju.edu.cn> * format Signed-off-by: mave <211220097@smail.nju.edu.cn> * format_test Signed-off-by: mave <211220097@smail.nju.edu.cn> * format apache license Signed-off-by: mave <211220097@smail.nju.edu.cn> --------- Signed-off-by: mave <211220097@smail.nju.edu.cn> 111 (fluid-cloudnative#4121) Signed-off-by: lianwg <1494923285@qq.com> Bump golang.org/x/net from 0.25.0 to 0.26.0 (fluid-cloudnative#4156) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.25.0 to 0.26.0. - [Commits](golang/net@v0.25.0...v0.26.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> modified the incorrect copyright time in file pkg/ddc/efc/cache.go (fluid-cloudnative#4125) Signed-off-by: hadoop <scanocdii@gmail.com> --- (fluid-cloudnative#4123) updated-dependencies: - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Build docker images for vineyard 0.22, To #54250932 (fluid-cloudnative#4159) Signed-off-by: cheyang <cheyang@163.com> Bump sigs.k8s.io/yaml from 1.3.0 to 1.4.0 (fluid-cloudnative#4157) Bumps [sigs.k8s.io/yaml](https://github.com/kubernetes-sigs/yaml) from 1.3.0 to 1.4.0. - [Release notes](https://github.com/kubernetes-sigs/yaml/releases) - [Changelog](https://github.com/kubernetes-sigs/yaml/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/yaml@v1.3.0...v1.4.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/yaml dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Fix typo of transformer, To #54583165 (fluid-cloudnative#4150) Signed-off-by: cheyang <cheyang@163.com> Build docker images for fixing transformers, To #54583162 (fluid-cloudnative#4161) Signed-off-by: cheyang <cheyang@163.com> change transfromer to transformers in load_data.go (fluid-cloudnative#4118) * change transfromer to transformers Signed-off-by: yayaaaaaaaaa <1435114933@qq.com> * Update load_data.go --------- Signed-off-by: yayaaaaaaaaa <1435114933@qq.com> Co-authored-by: cheyang <cheyang@163.com> addons: add dynamic mount examples (fluid-cloudnative#4148) * Add base image for fluid dynamic mount feature Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add juicefs examples for fluid dynamic mount feature Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * clean up mount point unconditionally Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Dump mount point logs to /var/log/fluid Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Anchor base image for dynamic mount example Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> change copyright year from 2022 to 2020 (fluid-cloudnative#4132) Signed-off-by: FluorescenceLight <1219804366@qq.com> bugfix: check corrupted mount point in utils.RemoveSymlink (fluid-cloudnative#4163) Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Bump github.com/spf13/cobra from 1.7.0 to 1.8.0 (fluid-cloudnative#4158) Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.7.0 to 1.8.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.7.0...v1.8.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> modify copyright time (fluid-cloudnative#4128) Signed-off-by: liuyun-0002 <2695993128@qq.com> change time from 2022 to 2020 (fluid-cloudnative#4134) Signed-off-by: chxwindows <2216940643@qq.com> changed the time of Copyright in the operation.go file to 2023 (fluid-cloudnative#4145) Signed-off-by: sishijiang <2524798309@qq.com> Bump go.uber.org/zap from 1.24.0 to 1.27.0 (fluid-cloudnative#3727) Bumps [go.uber.org/zap](https://github.com/uber-go/zap) from 1.24.0 to 1.27.0. - [Release notes](https://github.com/uber-go/zap/releases) - [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md) - [Commits](uber-go/zap@v1.24.0...v1.27.0) --- updated-dependencies: - dependency-name: go.uber.org/zap dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> refactor: rename `CreateUpdatePodForSchedulingHandler` to `FluidMutatingHandler` (fluid-cloudnative#4168) * Refactor fluid mutating handler Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Refactor fluid mutating handler Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Refactor fluid mutating handler Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> minorfix: pin libfuse version in dynamic mount example (fluid-cloudnative#4167) * pin libfuse version to fuse-3.16.2 Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * minorfix: add return of line Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Refactor admission webhook handler registration for better error handling and maintainability, To #57240825 (fluid-cloudnative#4170) Signed-off-by: cheyang <cheyang@163.com> Assign pod.namespace before mutation (fluid-cloudnative#4171) Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> minorfix: carefully handle pod.namespace to avoid side effect (fluid-cloudnative#4172) * carefully handle pod.namespace Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * carefully handle pod.namespace Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * carefully handle pod.namespace Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Build docker images for refactoring webhook, To #57240825 (fluid-cloudnative#4173) Signed-off-by: cheyang <cheyang@163.com> Bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (fluid-cloudnative#4164) Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.8.4 to 1.9.0. - [Release notes](https://github.com/stretchr/testify/releases) - [Commits](stretchr/testify@v1.8.4...v1.9.0) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> feat: support multiround sidecar injection (fluid-cloudnative#4175) * Prune unused code Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * refactor: move func CollectRuntimeInfosFromPVCs to webhook utils package Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Support multi-round sidecar injection Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Support multi-round sidecar injection Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * fix unit tests Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * fix unit tests Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add unit tests Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add unit tests Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> description （简单描述你的修改） (fluid-cloudnative#4149) Signed-off-by: bc-ace <2336474595@qq.com> docs: Correcting the usage steps of the CONTABUTING.md document (fluid-cloudnative#4176) Signed-off-by: wjp <wjp_199502@163.com> move dataflow affinity logic to fluidapp controller (fluid-cloudnative#4138) * use fluidapp to support data flow affinity Signed-off-by: xliuqq <xlzq1992@gmail.com> * make fluidapp dataop controller optional Signed-off-by: xliuqq <xlzq1992@gmail.com> * fix check Signed-off-by: xliuqq <xlzq1992@gmail.com> * add unit test for injectPodNodeLabelsToJob Signed-off-by: xliuqq <xlzq1992@gmail.com> * fix: use library.fluid.labels instead of fluid.io/managed-by Signed-off-by: xliuqq <xlzq1992@gmail.com> * fix comment error and reslove conflicts Signed-off-by: xliuqq <xlzq1992@gmail.com> * fix annotation nil error Signed-off-by: xliuqq <xlzq1992@gmail.com> * fix e2e test, serverless pod use serverless.fluid.io/inject and fluid.io/managed-by two labels Signed-off-by: xliuqq <xlzq1992@gmail.com> --------- Signed-off-by: xliuqq <xlzq1992@gmail.com> Build docker images for refactoring dataflow controller, To #57240825 (fluid-cloudnative#4181) Signed-off-by: cheyang <cheyang@163.com> wjl (fluid-cloudnative#4039) Signed-off-by: wjlwjlwjlwjlwjlwjlwjl <2931582547@qq.com> Co-authored-by: cheyang <cheyang@163.com> Bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (fluid-cloudnative#4166) Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.8.0...v1.8.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Update utils.go (fluid-cloudnative#4116) addcopyright Do not skip mutation for fluid pods (fluid-cloudnative#4184) Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Bump github.com/felixge/fgprof from 0.9.3 to 0.9.4 (fluid-cloudnative#4169) Bumps [github.com/felixge/fgprof](https://github.com/felixge/fgprof) from 0.9.3 to 0.9.4. - [Release notes](https://github.com/felixge/fgprof/releases) - [Commits](felixge/fgprof@v0.9.3...v0.9.4) --- updated-dependencies: - dependency-name: github.com/felixge/fgprof dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> bugfix: fix application controller manage pod lifecycle (fluid-cloudnative#4185) Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Bump github.com/go-logr/logr from 1.4.1 to 1.4.2 (fluid-cloudnative#4174) Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/go-logr/logr/releases) - [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md) - [Commits](go-logr/logr@v1.4.1...v1.4.2) --- updated-dependencies: - dependency-name: github.com/go-logr/logr dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> cm1 (fluid-cloudnative#4114) dataset add storageSize (fluid-cloudnative#4178) Signed-off-by: wangshulei098 <850732903@qq.com> Build docker images for specifying pvc storage size, To #54250932 (fluid-cloudnative#4187) Signed-off-by: cheyang <cheyang@163.com> docs: dev guide for en missing GOPATH setup (fluid-cloudnative#4188) Signed-off-by: backspace <backspace@backblog.me> Update operation_helm.go (fluid-cloudnative#4129) * Update operation_helm.go modify copyright time * Update operation_helm.go modify copyright time. Signed-off-by: rodestexas <1985056713@qq.com> --------- Signed-off-by: rodestexas <1985056713@qq.com> Bump k8s.io/klog/v2 from 2.120.1 to 2.130.1 (fluid-cloudnative#4183) Bumps [k8s.io/klog/v2](https://github.com/kubernetes/klog) from 2.120.1 to 2.130.1. - [Release notes](https://github.com/kubernetes/klog/releases) - [Changelog](https://github.com/kubernetes/klog/blob/main/RELEASE.md) - [Commits](kubernetes/klog@v2.120.1...v2.130.1) --- updated-dependencies: - dependency-name: k8s.io/klog/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> bugfix: allow users to override juicefs attr-cache and entry-cache options (fluid-cloudnative#4194) * bugfix: allow users override attr-cache and entry-cache in JuiceFS Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * go fmt Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Bump google.golang.org/grpc from 1.64.0 to 1.65.0 (fluid-cloudnative#4191) Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.64.0 to 1.65.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.64.0...v1.65.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Update go.mod to comply with Go 1.21 toolchain syntax (fluid-cloudnative#4196) * Update go mod to 1.21.10, To #57240825 Signed-off-by: cheyang <cheyang@163.com> * Update go mod to 1.21.10, To #57240825 Signed-off-by: cheyang <cheyang@163.com> --------- Signed-off-by: cheyang <cheyang@163.com> Build docker images for fixing juicefs timeout, To #57240825 (fluid-cloudnative#4197) Signed-off-by: cheyang <cheyang@163.com> bugfix: fix early break when cleaning mount point in NodeUnpublishVolume (fluid-cloudnative#4198) * Clean up corrupted mount points in NodeUnpublishVolume Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Clean up corrupted mount points in NodeUnpublishVolume Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> This pr is to add the translation of the Apache License notice (fluid-cloudnative#4078) * Update thin.go Signed-off-by: cheyang <cheyang@163.com> * Update thin.go Signed-off-by: cheyang <cheyang@163.com> * Update thin.go license header, To #54250932 Signed-off-by: cheyang <cheyang@163.com> * Update thin.go license header, To #54250932 Signed-off-by: cheyang <cheyang@163.com> --------- Signed-off-by: cheyang <cheyang@163.com> Co-authored-by: cheyang <cheyang@163.com> Bump github.com/agiledragon/gomonkey/v2 from 2.11.0 to 2.12.0 (fluid-cloudnative#4199) Bumps [github.com/agiledragon/gomonkey/v2](https://github.com/agiledragon/gomonkey) from 2.11.0 to 2.12.0. - [Release notes](https://github.com/agiledragon/gomonkey/releases) - [Commits](agiledragon/gomonkey@v2.11.0...v2.12.0) --- updated-dependencies: - dependency-name: github.com/agiledragon/gomonkey/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> bugfix: fix jindoruntime name cannot contain jindofs (fluid-cloudnative#4202) * bugfix: JindoRuntime cannot use a name containing "jindofs" Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * todo: add todo for handling fullnameOverride Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> revert: "upgrade jindocache to 6.4.0 version (fluid-cloudnative#4126)" and downgrade JindoCache to 6.2.0 (fluid-cloudnative#4205) Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Build docker images for reverting jindoruntime from 6.4 to 6.2, To #57978385 (fluid-cloudnative#4206) Signed-off-by: cheyang <cheyang@163.com> Bump golang.org/x/net from 0.26.0 to 0.27.0 (fluid-cloudnative#4200) Bumps [golang.org/x/net](https://github.com/golang/net) from 0.26.0 to 0.27.0. - [Commits](golang/net@v0.26.0...v0.27.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Prepare 1.0.2, To #57978385 (fluid-cloudnative#4207) Signed-off-by: cheyang <cheyang@163.com> Delete the unused rbac roles for vineyard runtime. (fluid-cloudnative#4208) Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com> Update docker image to fluid 1.0.2, To #54250932 (fluid-cloudnative#4210) Signed-off-by: cheyang <cheyang@163.com> Bump github.com/golang/glog from 1.2.1 to 1.2.2 (fluid-cloudnative#4204) Bumps [github.com/golang/glog](https://github.com/golang/glog) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/golang/glog/releases) - [Commits](golang/glog@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: github.com/golang/glog dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> bugfix: support sync ak/sk secret key-values in JindoRuntime (fluid-cloudnative#4212) * bugfix: support sync ak/sk secret key-values in JindoRuntime Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Update CHANGELOG.md Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> del create pod role of juicefs runtime (fluid-cloudnative#4215) Signed-off-by: zwwhdls <zww@hdls.me> refactor: separate image and tag in helm values (fluid-cloudnative#4216) * Separate images in values.yaml into repo, image and tag Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Separate images in values.yaml into imagePrefix, imageName and imageTag Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * refactor: transform control plane images with helper function Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * refactor: transform runtime images with helper function Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Refactor fluid helm chart, To #54583162 (fluid-cloudnative#4218) Signed-off-by: cheyang <cheyang@163.com> Add no cache option to Makefile, To #54583162 (fluid-cloudnative#4217) Signed-off-by: cheyang <cheyang@163.com> update scorecard link (fluid-cloudnative#4220) Signed-off-by: fsl <1171313930@qq.com> feat: pass extra args when building fuse sidecar mutators (fluid-cloudnative#4223) * Rename `MutatorBuildOpts` to `MutatorBuildArgs` Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Pass extraArgs when building platform-specific mutators Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add unit tests Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add unit tests Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> enhance: add github actions workflow e2e tests (fluid-cloudnative#4224) * Add integration.yml Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add github actions e2e for alluxio Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add testcase for juicefsruntime & jindoruntime Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Gracefully clean up resources Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Dump e2e environment info with diagnose scripts and upload it to github action artifacts Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Rename github actions workflow names Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Purge out-of-date testcases Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> minorfix: set read-all permission for e2e functionality check workflow (fluid-cloudnative#4226) * Minorfix: set read-all permission for e2e functionality check workflow Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add empty line EOF Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> bugfix: fix kind e2e test images (fluid-cloudnative#4232) * Fix version replace in gha-e2e Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Optimize diagnose shell scripts Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> fix Variable Naming Convention for DEFAULT_MASTER_RPC_PORT in CamelCase (fluid-cloudnative#4234) * Change Constant Variable Naming Convention for DEFAULT_MASTER_RPC_PORT in camelCase format defined in pkg/ddc/jindo/const.go and its reference in /pkg/ddc/jindo/transform.go Signed-off-by: SouthWest7 <1403572259@qq.com> * Change Constant Variable Naming Convention for DEFAULT_MASTER_RPC_PORT in camelCase format defined in pkg/ddc/jindo/const.go and its reference in /pkg/ddc/jindo/transform.go Signed-off-by: SouthWest7 <1403572259@qq.com> * Change Constant Variable Naming Convention for DEFAULT_MASTER_RPC_PORT in camelCase format defined in pkg/ddc/jindo/const.go and its reference in /pkg/ddc/jindo/transform.go Signed-off-by: SouthWest7 <1403572259@qq.com> * Change Constant Variable Naming Convention for DEFAULT_MASTER_RPC_PORT in camelCase format defined in pkg/ddc/jindo/const.go and its reference in /pkg/ddc/jindo/transform.go Signed-off-by: SouthWest7 <1403572259@qq.com> --------- Signed-off-by: SouthWest7 <1403572259@qq.com> Change Constant Variable Naming Convention for CSI_DRIVER in camelCase format (fluid-cloudnative#4229) * Update const.go * Update const.go bugfix: fix version replace in gha-e2e (fluid-cloudnative#4235) * Fix version replace in gha-e2e Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Fix version replace in gha-e2e Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> Update docker images for refactoring sidecar mutator (fluid-cloudnative#4230) * Update docker images for refactoring sidecar mutator, To #54583162 Signed-off-by: cheyang <cheyang@163.com> * Update docker images for refactoring sidecar mutator, To #54583162 Signed-off-by: cheyang <cheyang@163.com> * Update docker images for refactoring sidecar mutator, To #54583162 Signed-off-by: cheyang <cheyang@163.com> --------- Signed-off-by: cheyang <cheyang@163.com> juicefs: use exec in juicefs pod to avoid ignore signal (fluid-cloudnative#4236) * feat: use exec in juicefs pod to avoid ignore signal Signed-off-by: zwwhdls <zww@hdls.me> * feat: use exec in juicefs pod to avoid ignore signal Signed-off-by: zwwhdls <zww@hdls.me> * fix unittest Signed-off-by: zwwhdls <zww@hdls.me> --------- Signed-off-by: zwwhdls <zww@hdls.me> update juicefs default imaghe (fluid-cloudnative#4237) Signed-off-by: zwwhdls <zww@hdls.me> Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (fluid-cloudnative#4239) Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.3 to 2.4.0. - [Release notes](https://github.com/ossf/scorecard-action/releases) - [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md) - [Commits](ossf/scorecard-action@dc50aa9...62b2cac) --- updated-dependencies: - dependency-name: ossf/scorecard-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Update controller-runtime to v1.17.5, To #57240825 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #55315018 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Update controller-runtime to v1.17.5, To #57240825 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Update controller-runtime to v1.17.5, To #57240825 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Refactoring the client cache mode, To #54583162 Signed-off-by: cheyang <cheyang@163.com> Fix compiling issue, To #57978385 Signed-off-by: cheyang <cheyang@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
The generated PVC and PV have a fixed size of 100 Pi and cannot be changed. In a namespace with a Resourcequota set for storage, it is not possible to create such large PV and PVC. Therefore, the size needs to be configurable.
Ⅱ. Does this pull request fix one issue?
fixes #4177
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
“pvc.fluid.io/resources.requests.storage” as the annotation key on Dataset to specify the desired storage size for the generated PVC. If not set, or if the storage size format is incorrect, it will be set to the default value of 100Pi.
Ⅴ. Special notes for reviews