Skip to content

Conversation

@cheyang
Copy link
Collaborator

@cheyang cheyang commented May 28, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #4140

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

cheyang added 3 commits May 28, 2024 18:19
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
Signed-off-by: cheyang <cheyang@163.com>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 0666e0f into fluid-cloudnative:master May 30, 2024
cheyang added a commit to Ametsuji-akiya/fluid that referenced this pull request Jul 16, 2024
* Fix logging for  runtime, To #54583165

Signed-off-by: cheyang <cheyang@163.com>

* Fix logging issue for  runtime, To #54583165

Signed-off-by: cheyang <cheyang@163.com>

* Fix logging issue for  runtime, To #54583165

Signed-off-by: cheyang <cheyang@163.com>

---------

Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang deleted the fix_npe_of_runtime_controller branch January 17, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]Panic in AlluxioRuntime reconciler due to reflect.Value.IsNil call on struct Value

2 participants