support parallel tasks for cron datamigrate #3732
Conversation
Signed-off-by: xliuqq <xlzq1992@gmail.com>
Signed-off-by: xliuqq <xlzq1992@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3732 +/- ##
==========================================
- Coverage 64.40% 64.31% -0.09%
==========================================
Files 474 474
Lines 28339 28422 +83
==========================================
+ Hits 18252 18281 +29
- Misses 7913 7967 +54
Partials 2174 2174 ☔ View full report in Codecov by Sentry. |
| parallelism: 1 | ||
| {{- if gt (.Values.datamigrate.parallelism | int) 1 }} | ||
| # when using parallel tasks, default suspend is true, the reconciler will set it to false after scale the workers statefulset. | ||
| suspend: true |
There was a problem hiding this comment.
Which Kubernetes version can support this?
There was a problem hiding this comment.
job suspend field release notes: kubernetes/enhancements#2232
Alpha release target (x.y): 1.21, need explictly enable the SuspendJob feature gate;
Beta release target (x.y): 1.22, gated by SuspendJob feature flag (enabled by default);
Stable release target (x.y): 1.24
There was a problem hiding this comment.
So I think we should stress the known limitations in the documentation. The endusers could be aware of this.
Signed-off-by: xliuqq <xlzq1992@gmail.com>
|
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* support parallel tasks for cron datamigrate Signed-off-by: xliuqq <xlzq1992@gmail.com> * update logs Signed-off-by: xliuqq <xlzq1992@gmail.com> * fix: add docs for parallel cron datamigrate Signed-off-by: xliuqq <xlzq1992@gmail.com> --------- Signed-off-by: xliuqq <xlzq1992@gmail.com> Signed-off-by: Ricky-Daxia <1915754435@qq.com>
Ⅰ. Describe what this PR does
support parallel data migrate for cron policy.
previous pr see #3645.
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews