Fix incorrect conversion between integer types #3688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3688 +/- ##
==========================================
- Coverage 64.47% 64.46% -0.01%
==========================================
Files 471 471
Lines 28140 28149 +9
==========================================
+ Hits 18142 18147 +5
- Misses 7844 7847 +3
- Partials 2154 2155 +1 ☔ View full report in Codecov by Sentry. |
Collaborator
|
/test fluid-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xliuqq
pushed a commit
to xliuqq/fluid
that referenced
this pull request
Jan 17, 2024
Signed-off-by: ZhangXiaozheng <zhang__xiaozheng@outlook.com>
xliuqq
added a commit
to xliuqq/fluid
that referenced
this pull request
Jan 17, 2024
…tive#3688)" This reverts commit a015ab3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
This PR fix some incorrect conversions between integer types. In some ddc's operation, the
uint64type is convert toint64directly, which may provide unexpected return value.Ⅱ. Does this pull request fix one issue?
NONE
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Add some unit tests in which the return value is negative.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews