Auto infer engine implementation to support multi-engine Runtimes #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
…DatasetEngine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
…orts` Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3672 +/- ##
==========================================
+ Coverage 64.31% 64.40% +0.08%
==========================================
Files 444 444
Lines 26780 26797 +17
==========================================
+ Hits 17223 17258 +35
+ Misses 7542 7524 -18
Partials 2015 2015 ☔ View full report in Codecov by Sentry. |
Collaborator
|
/test fluid-e2e |
Member
Author
|
/retest |
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
… compatibility Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
|
Member
Author
|
/test fluid-e2e |
1 similar comment
Member
Author
|
/test fluid-e2e |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xliuqq
pushed a commit
to xliuqq/fluid
that referenced
this pull request
Jan 9, 2024
…uid-cloudnative#3672) * Add missing valueFile property in JuiceFSRuntime's status when syncing Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add missing valueFile property in ThinRuntime's status when syncing Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Add `engineImpl` for specifying runtime's backended engines Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Change runtimeType to engineImpl for JindoFS Engine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Change runtimeType to engineImpl for JindoFSx Engine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Change runtimeType to engineImpl for JindoCache Engine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Change runtimeType to engineImpl for Alluxio Engine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Change runtimeType to engineImpl for JuiceFS Engine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Change runtimeType to engineImpl for GooseFS Engine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Fix unit tests Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Change runtimeType to engineImpl for Thin Engine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Change runtimeType to engineImpl for EFC Engine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Fix thinruntime not to use ddc.InferEngineImpl() because of ReferenceDatasetEngine Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Auto-infer engine implementation for Operation Reconciler Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Change port allocator port reservation func to `jindofsx.GetReservedPorts` Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Fix Data Operation helm installation mistake Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> * Hack engine.getRuntimeInfo's runtimeType with engineImpl for backward compatibility Signed-off-by: trafalgarzzz <trafalgarz@outlook.com> --------- Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
Fluid has supported more and more runtimes and some of the runtimes also have different underlying implementations. Such implementations are supported in code with different
Engine. Before all these concepts turn into a mess-up, we have to clearly define the relationship betweenEnginesandRuntimesand all the related concepts in the code.This PR does the following changes:
engineImpl, specifying the underlying engine implementation.engineImplhas a one-to-one relation with a concreteEngine.engineImpl=="jindocache"runtimeTypenow only refers to what the runtime is so it has a one-to-one relation with a specific runtime CRD.runtimeType=="alluxio"Other minor changes：
IMPORTANT:
Ⅱ. Does this pull request fix one issue?
Resolves #3673
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews