Skip to content

Add the controller and rbac yaml for vineyard runtime. #3659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 1 commit into from
Dec 27, 2023
Merged

Add the controller and rbac yaml for vineyard runtime. #3659

fluid-e2e-bot merged 1 commit into from
Dec 27, 2023

Conversation

@dashanji
Copy link
Contributor

@dashanji dashanji commented Dec 20, 2023 •
edited
Loading

Ⅰ. Describe what this PR does

Fixes part of #3528. A follow-up of #3624

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Dec 20, 2023

Hi @dashanji. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cheyang
cheyang reviewed Dec 21, 2023
View reviewed changes
charts/fluid/fluid/templates/role/vineyard/rbac.yaml Outdated
- apiGroups:
- ""
resources:
- pods/exec
Copy link
Collaborator

@cheyang cheyang Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need pods/exec in Vineyard controller?

Copy link
Contributor Author

@dashanji dashanji Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.

cheyang
cheyang reviewed Dec 21, 2023
View reviewed changes
charts/fluid/fluid/templates/role/vineyard/rbac.yaml Outdated
- apiGroups:
- ""
resources:
- secrets
Copy link
Collaborator

@cheyang cheyang Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need the right on secrets?

Copy link
Contributor Author

@dashanji dashanji Dec 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted.

@dashanji dashanji force-pushed the add-controller-and-rbac-for-vineyard-runtime branch from 78a14b9 to 5c38864 Compare December 21, 2023 03:35
@codecov
Copy link

codecov bot commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9aca705) 64.31% compared to head (867fbca) 64.31%.
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3659   +/-   ##
=======================================
  Coverage   64.31%   64.31%           
=======================================
  Files         444      444           
  Lines       26780    26780           
=======================================
  Hits        17223    17223           
  Misses       7542     7542           
  Partials     2015     2015

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheyang cheyang requested a review from TrafalgarZZZ December 25, 2023 08:13
TrafalgarZZZ
TrafalgarZZZ reviewed Dec 26, 2023
View reviewed changes
charts/fluid/fluid/templates/controller/vineyardruntime_controller.yaml Outdated
name: manager
command: ["vineyardruntime-controller", "start"]
args:
- --development=true
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about setting development to false for production environment?

Copy link
Contributor Author

@dashanji dashanji Dec 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to me.

@dashanji
Add the controller and rbac yaml for vineyard runtime.
867fbca 
Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@dashanji dashanji force-pushed the add-controller-and-rbac-for-vineyard-runtime branch from 5c38864 to 867fbca Compare December 26, 2023 08:00
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 26, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
3.5% Duplication on New Code

See analysis details on SonarCloud

@TrafalgarZZZ
Copy link
Member

TrafalgarZZZ commented Dec 27, 2023

/lgtm

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Dec 27, 2023
@cheyang cheyang self-requested a review December 27, 2023 02:57
cheyang
cheyang approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 959e9b3 into fluid-cloudnative:master Dec 27, 2023
@dashanji dashanji deleted the add-controller-and-rbac-for-vineyard-runtime branch December 27, 2023 05:00
xliuqq pushed a commit to xliuqq/fluid that referenced this pull request Jan 9, 2024
@dashanji @xliuqq
Add the controller and rbac yaml for vineyard runtime. (fluid-cloudna…
acc024a 
…tive#3659)

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@RongGu RongGu mentioned this pull request Aug 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrafalgarZZZ TrafalgarZZZ TrafalgarZZZ left review comments

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

@TrafalgarZZZ TrafalgarZZZ

Labels

approved lgtm needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dashanji @TrafalgarZZZ @cheyang