Skip to content

Conversation

@xliuqq
Copy link
Collaborator

@xliuqq xliuqq commented Dec 20, 2023

Ⅰ. Describe what this PR does

Fix Alluxio master in HA mode start error.

Ⅱ. Does this pull request fix one issue?

fixes #3656

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: xliuqq <xlzq1992@gmail.com>
Signed-off-by: xliuqq <xlzq1992@gmail.com>
@cheyang
Copy link
Collaborator

cheyang commented Dec 20, 2023

@xliuqq please fix the ut issue. thanks.

Signed-off-by: xliuqq <xlzq1992@gmail.com>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
1 Security Hotspot
No data about Coverage
31.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang
Copy link
Collaborator

cheyang commented Dec 21, 2023

/test fluid-e2e

@cheyang cheyang merged commit bbc940e into fluid-cloudnative:master Dec 21, 2023
xliuqq added a commit to xliuqq/fluid that referenced this pull request Dec 23, 2023
* fix alluxio ha master start error

Signed-off-by: xliuqq <xlzq1992@gmail.com>

* move log inside the ha judgement block

Signed-off-by: xliuqq <xlzq1992@gmail.com>

* fix alluxio ha master unit test

Signed-off-by: xliuqq <xlzq1992@gmail.com>

---------

Signed-off-by: xliuqq <xlzq1992@gmail.com>
@xliuqq xliuqq deleted the ha-fix branch December 23, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]Alluxio master in HA mode is not supported

2 participants